From: David Miller <davem@redhat.com>
To: eric.dumazet@gmail.com
Cc: ast@plumgrid.com, netdev@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCH v2 net-next] inet: fix a UFO regression
Date: Fri, 08 Nov 2013 02:08:28 -0500 (EST) [thread overview]
Message-ID: <20131108.020828.965655576855775437.davem@redhat.com> (raw)
In-Reply-To: <1383877926.9412.145.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 07 Nov 2013 18:32:06 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> While testing virtio_net and skb_segment() changes, Hannes reported
> that UFO was sending wrong frames.
>
> It appears this was introduced by a recent commit :
> 8c3a897bfab1 ("inet: restore gso for vxlan")
>
> The old condition to perform IP frag was :
>
> tunnel = !!skb->encapsulation;
> ...
> if (!tunnel && proto == IPPROTO_UDP) {
>
> So the new one should be :
>
> udpfrag = !skb->encapsulation && proto == IPPROTO_UDP;
> ...
> if (udpfrag) {
>
> Initialization of udpfrag must be done before call
> to ops->callbacks.gso_segment(skb, features), as
> skb_udp_tunnel_segment() clears skb->encapsulation
>
> (We want udpfrag to be true for UFO, false for VXLAN)
>
> With help from Alexei Starovoitov
>
> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks a lot Eric.
next prev parent reply other threads:[~2013-11-08 7:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 23:37 vxlan gso is broken by stackable gso_segment() Alexei Starovoitov
2013-10-25 0:41 ` Eric Dumazet
2013-10-25 1:59 ` Alexei Starovoitov
2013-10-25 4:06 ` Eric Dumazet
2013-10-25 9:09 ` Eric Dumazet
2013-10-25 22:18 ` David Miller
2013-10-25 22:41 ` Alexei Starovoitov
2013-10-25 23:10 ` David Miller
2013-10-25 23:25 ` Eric Dumazet
2013-10-26 0:26 ` [PATCH net-next] tcp: gso: fix truesize tracking Eric Dumazet
2013-10-26 1:46 ` Alexei Starovoitov
2013-10-28 4:58 ` David Miller
2013-10-29 4:05 ` David Miller
2013-10-26 0:52 ` vxlan gso is broken by stackable gso_segment() Eric Dumazet
2013-10-26 1:25 ` [PATCH net-next] veth: extend features to support tunneling Eric Dumazet
2013-10-26 2:22 ` Alexei Starovoitov
2013-10-26 4:13 ` Eric Dumazet
2013-10-28 4:58 ` David Miller
2013-10-28 1:18 ` [PATCH net-next] inet: restore gso for vxlan Eric Dumazet
2013-10-28 4:25 ` David Miller
2013-11-07 22:33 ` Eric Dumazet
2013-11-07 23:27 ` Alexei Starovoitov
2013-11-08 0:44 ` [PATCH net-next] inet: fix a UFO regression Eric Dumazet
2013-11-08 1:39 ` Alexei Starovoitov
2013-11-08 2:08 ` Eric Dumazet
2013-11-08 2:32 ` [PATCH v2 " Eric Dumazet
2013-11-08 7:08 ` David Miller [this message]
2013-11-16 20:23 ` [PATCH net-next] inet: restore gso for vxlan Or Gerlitz
2013-11-16 20:50 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2013-11-08 5:44 [PATCH v2 net-next] inet: fix a UFO regression Alexei Starovoitov
2013-11-08 5:50 ` Eric Dumazet
2013-11-08 6:41 ` Sridhar Samudrala
2013-11-08 12:18 ` Eric Dumazet
2013-11-08 20:20 ` Sridhar Samudrala
2013-11-08 20:57 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108.020828.965655576855775437.davem@redhat.com \
--to=davem@redhat.com \
--cc=ast@plumgrid.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).