From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: florent.fourcot@enst-bretagne.fr, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/3] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt
Date: Fri, 08 Nov 2013 13:43:24 -0500 (EST) [thread overview]
Message-ID: <20131108.134324.1679400843866741415.davem@davemloft.net> (raw)
In-Reply-To: <20131108122749.GA5876@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 8 Nov 2013 13:27:49 +0100
> On Thu, Nov 07, 2013 at 05:53:12PM +0100, Florent Fourcot wrote:
>> It is already possible to set/put/renew a label
>> with IPV6_FLOWLABEL_MGR and setsockopt. This patch
>> add the possibility to get information about this
>> label (current value, time before expiration, etc).
>>
>> It helps application to take decision for a renew
>> or a release of the label.
>>
>> v2:
>> * Add spin_lock to prevent race condition
>> * return -ENOENT if no result found
>> * check if flr_action is GET
>>
>> v3:
>> * move the spin_lock to protect only the
>> relevant code
>>
>> Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
>
> There still are some locking anomalies in ip6_flowlabel. But none
> has something to do with your patches. E.g. mem_check runs without
> rcu_read_lock.
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks.
prev parent reply other threads:[~2013-11-08 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 16:53 [PATCH net-next v3 1/3] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt Florent Fourcot
2013-11-07 16:53 ` [PATCH net-next 2/3] ipv6: increase maximum lifetime of flow labels Florent Fourcot
2013-11-08 12:34 ` Hannes Frederic Sowa
2013-11-08 18:44 ` David Miller
2013-11-07 16:53 ` [PATCH net-next v2 3/3] ipv6: protect flow label renew against GC Florent Fourcot
2013-11-08 12:29 ` Hannes Frederic Sowa
2013-11-08 18:44 ` David Miller
2013-11-07 16:56 ` [PATCH net-next v3 1/3] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt Florent Fourcot
2013-11-08 12:27 ` Hannes Frederic Sowa
2013-11-08 18:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108.134324.1679400843866741415.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florent.fourcot@enst-bretagne.fr \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).