From: David Miller <davem@davemloft.net>
To: andreas@fatal.se
Cc: netdev@vger.kernel.org, shemminger@networkplumber.org
Subject: Re: [PATCH] Fix "ip rule delete table 256"
Date: Fri, 08 Nov 2013 14:54:01 -0500 (EST) [thread overview]
Message-ID: <20131108.145401.703012257935119294.davem@davemloft.net> (raw)
In-Reply-To: <20131107172638.GA6110@amd64.fatal.se>
From: Andreas Henriksson <andreas@fatal.se>
Date: Thu, 7 Nov 2013 18:26:38 +0100
> When trying to delete a table >= 256 using iproute2 the local table
> will be deleted.
> The table id is specified as a netlink attribute when it needs more then
> 8 bits and iproute2 then sets the table field to RT_TABLE_UNSPEC (0).
> Preconditions to matching the table id in the rule delete code
> doesn't seem to take the "table id in netlink attribute" into condition
> so the frh_get_table helper function never gets to do its job when
> matching against current rule.
> Use the helper function twice instead of peaking at the table value directly.
>
> Originally reported at: http://bugs.debian.org/724783
>
> Reported-by: Nicolas HICHER <nhicher@avencall.com>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
Good catch, applied and queued up for -stable, thanks!
prev parent reply other threads:[~2013-11-08 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 17:26 [PATCH] Fix "ip rule delete table 256" Andreas Henriksson
2013-11-08 19:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108.145401.703012257935119294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
--cc=shemminger@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).