* [PATCH] ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh
@ 2013-11-08 18:26 Hannes Frederic Sowa
2013-11-11 6:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Frederic Sowa @ 2013-11-08 18:26 UTC (permalink / raw)
To: netdev; +Cc: florent.fourcot
Fixes a suspicious rcu derference warning.
Cc: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/ip6_flowlabel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c
index 98fdcc6..e7fb710 100644
--- a/net/ipv6/ip6_flowlabel.c
+++ b/net/ipv6/ip6_flowlabel.c
@@ -457,8 +457,10 @@ static int mem_check(struct sock *sk)
if (room > FL_MAX_SIZE - FL_MAX_PER_SOCK)
return 0;
+ rcu_read_lock_bh();
for_each_sk_fl_rcu(np, sfl)
count++;
+ rcu_read_unlock_bh();
if (room <= 0 ||
((count >= FL_MAX_PER_SOCK ||
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh
2013-11-08 18:26 [PATCH] ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh Hannes Frederic Sowa
@ 2013-11-11 6:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-11-11 6:26 UTC (permalink / raw)
To: hannes; +Cc: netdev, florent.fourcot
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 8 Nov 2013 19:26:21 +0100
> Fixes a suspicious rcu derference warning.
>
> Cc: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Looks good, applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-11 6:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 18:26 [PATCH] ipv6: protect for_each_sk_fl_rcu in mem_check with rcu_read_lock_bh Hannes Frederic Sowa
2013-11-11 6:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).