From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: netdev@vger.kernel.org, amirv@mellanox.com, eyalpe@mellanox.com
Subject: Re: [PATCH net-next FIX] RDMA/cma: Fix build breakage when infiniband is built-in
Date: Sun, 10 Nov 2013 21:03:55 -0500 (EST) [thread overview]
Message-ID: <20131110.210355.1669362951389274888.davem@davemloft.net> (raw)
In-Reply-To: <1384090080-1862-1-git-send-email-ogerlitz@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Sun, 10 Nov 2013 15:28:00 +0200
> From: Eyal Perry <eyalpe@mellanox.com>
>
> Commit eb072c4 ("RDMA/cma: Set IBoE SL (user-priority) by egress map when using
> vlans"), broke the build when CONFIG_VLAN_8021Q=m and CONFIG_INFINIBAND=y,
> because the rdma_cm module attempted to call vlan_dev_get_egress_qos_mask()
> which in that case is a modular code being called from built-in kernel code.
>
> Fix this by adding a Kconfig dependency to prevent the rdma_cm code from being
> built in when 8021Q is built modular, in a similar manner we do with IPv6.
>
> Signed-off-by: Eyal Perry <eyalpe@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> ---
>
> Dave, this fixes an issue with the mentioned commit which is in net-next
Please just move vlan_dev_get_egress_qos_mask into include/linux/if_vlan.h
and make it an inline function.
These Kconfig restrictions are just beyond silly and unnecessary.
I bet the IPV6 one already there can be killed by moving some things
into net/ipv6/*_core.c files as well.
next prev parent reply other threads:[~2013-11-11 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 13:28 [PATCH net-next FIX] RDMA/cma: Fix build breakage when infiniband is built-in Or Gerlitz
2013-11-11 2:03 ` David Miller [this message]
2013-11-11 5:43 ` David Miller
2013-11-12 8:14 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131110.210355.1669362951389274888.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=eyalpe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).