From: Stephen Hemminger <stephen@networkplumber.org>
To: baker.kernel@gmail.com
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
steffen.klassert@secunet.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] xfrm: check function pointer of xfrm_mgr before use it
Date: Mon, 11 Nov 2013 10:52:22 -0800 [thread overview]
Message-ID: <20131111105222.4857587a@samsung-9> (raw)
In-Reply-To: <1384093556-8987-1-git-send-email-baker.kernel@gmail.com>
On Sun, 10 Nov 2013 22:25:56 +0800
baker.kernel@gmail.com wrote:
> For current kernel source, there is no problem.
>
> In our vpn product, we need a xfrm_km in kernel module
> to monitor the xfrm state change.
> thus, the 'acquire' and 'compile_policy' may be NULL.
>
> So I think we should do the check before use it
The upstream kernel does not accept or make changes to accommodate code that
is not part of the kernel source.
The only way this change would be considered would be as part of a submission
of the kernel module. I.e. part 1 of N.
So if you are willing to submit your module upstream under GPLv2, then
it will be reviewed an possibly accepted. If you just want this change to
make your product easier, then sorry no.
prev parent reply other threads:[~2013-11-11 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 14:25 [PATCH net-next] xfrm: check function pointer of xfrm_mgr before use it baker.kernel
2013-11-10 19:03 ` Sergei Shtylyov
2013-11-10 23:31 ` [PATCH V2 " baker.kernel
2013-11-11 5:09 ` David Miller
2013-11-11 6:39 ` [PATCH v3 net-next] xfrm: Add check to prevent un-complete key manager baker.kernel
2013-11-11 7:11 ` Fan Du
2013-11-11 19:04 ` David Miller
2013-11-11 18:52 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111105222.4857587a@samsung-9 \
--to=stephen@networkplumber.org \
--cc=baker.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox