netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Sujith Manoharan <sujith@msujith.org>,
	netdev@vger.kernel.org, Dave Taht <dave.taht@gmail.com>
Subject: Re: TCP performance regression
Date: Tue, 12 Nov 2013 08:42:43 +0100	[thread overview]
Message-ID: <20131112074243.GA10318@1wt.eu> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B73FD@saturn3.aculab.com>

On Mon, Nov 11, 2013 at 04:35:30PM -0000, David Laight wrote:
> > > It should be ok if the mac driver only gives the hardware a small
> > > number of bytes/packets - or one appropriate for the link speed.
> > 
> > There is some confusion here.
> > 
> > mvneta has a TX ring buffer, which can hold up to 532 TX descriptors.
> > 
> > If this driver used skb_orphan(), a single TCP flow could use the whole
> > TX ring.
> > 
> > TCP Small Queue would only limit the number of skbs on Qdisc.
> > 
> > Try then to send a ping message, it will have to wait a lot.
> 
> 532 is a ridiculously large number especially for a slow interface.
> At a guess you don't want more than 10-20ms of data in the tx ring.

Well, it's not *that* large, 532 descriptors is 800 kB or 6.4 ms with
1500-bytes packets, and 273 microseconds for 64-byte packets. In fact
it's not a slow interface, it's the systems it runs on which are
generally not that fast. For example it is possible to saturate two
gig ports at once on a single-core Armada370. But you need buffers
large enough to compensate for the context switch time if you use
multiple threads to send.

Regards,
Willy

  parent reply	other threads:[~2013-11-12  7:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11  5:30 TCP performance regression Sujith Manoharan
2013-11-11  5:55 ` Eric Dumazet
2013-11-11  6:07   ` Sujith Manoharan
2013-11-11  6:54     ` Eric Dumazet
2013-11-11  8:19       ` Sujith Manoharan
2013-11-11 14:27         ` Eric Dumazet
2013-11-11 14:39           ` Eric Dumazet
2013-11-11 16:44             ` Eric Dumazet
2013-11-11 15:05           ` David Laight
2013-11-11 15:29             ` Eric Dumazet
2013-11-11 15:43               ` David Laight
2013-11-11 16:17                 ` Eric Dumazet
2013-11-11 16:35                   ` David Laight
2013-11-11 17:41                     ` Eric Dumazet
2013-11-12  7:42                     ` Willy Tarreau [this message]
2013-11-12 14:16                       ` Eric Dumazet
2013-11-14  9:54                       ` Dave Taht
2013-11-11 16:13           ` Sujith Manoharan
2013-11-11 16:38             ` Felix Fietkau
2013-11-11 17:38               ` Eric Dumazet
2013-11-11 17:44                 ` Felix Fietkau
2013-11-11 18:03                 ` Dave Taht
2013-11-11 18:29                   ` Sujith Manoharan
2013-11-11 18:31                   ` Dave Taht
2013-11-11 19:11                     ` Ben Greear
2013-11-11 19:24                       ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131112074243.GA10318@1wt.eu \
    --to=w@1wt.eu \
    --cc=David.Laight@ACULAB.COM \
    --cc=dave.taht@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sujith@msujith.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).