From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH] net/7990: Make lance_private.name const
Date: Wed, 13 Nov 2013 15:13:01 -0500 (EST) [thread overview]
Message-ID: <20131113.151301.100218641838867631.davem@davemloft.net> (raw)
In-Reply-To: <CAMuHMdXyqOATvE8e=3Ed17bwiDRE8w=B=xKuYwd5qorxqA0BJg@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 13 Nov 2013 09:54:18 +0100
> On Wed, Nov 13, 2013 at 12:16 AM, David Miller <davem@davemloft.net> wrote:
>>>> And remember about checkpatch.pl which was hardly content with the patch.
>>>
>>> Only because checkpatch looks at the _new_ lines, and doesn't compare the
>>> styles of the old and new lines.
>>
>> You really should fix the line you are changing to use tabs, please respin
>> with this in mind, thanks.
>
> As that would add more to the TAB/space mess^H^H^Hix, I prepended a
> patch to fix all whitespace errors.
I implicitly asked you not to do this, now things are more difficult
and your original change will take longer to integrate.
Becuase now it isn't a patch set I can easily just apply quickly in
the current merge window, and it's therefore a series you'll have to
resubmit later when the merge window closes and the net-next tree
opens up again.
Sorry.
next prev parent reply other threads:[~2013-11-13 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 19:14 [PATCH] net/7990: Make lance_private.name const Geert Uytterhoeven
2013-11-12 22:04 ` Sergei Shtylyov
2013-11-12 21:12 ` David Miller
2013-11-12 23:40 ` Sergei Shtylyov
2013-11-12 22:44 ` Geert Uytterhoeven
2013-11-12 23:16 ` David Miller
2013-11-13 8:54 ` Geert Uytterhoeven
2013-11-13 20:13 ` David Miller [this message]
2013-11-14 8:37 ` Geert Uytterhoeven
2013-11-14 9:11 ` David Miller
2013-11-13 0:04 ` Sergei Shtylyov
2013-11-12 23:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113.151301.100218641838867631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).