Re: [PATCH] 6lowpan: Uncompression of traffic class field was incorrect

[David Miller <davem@davemloft.net>]

From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Date: Wed, 13 Nov 2013 11:03:39 +0200

> If priority/traffic class field in IPv6 header is set (seen when
> using ssh), the uncompression sets the TC and Flow fields incorrectly.
> 
> Example:
> 
> This is IPv6 header of a sent packet. Note the priority/TC (=1) in
> the first byte.
> 
> 00000000: 61 00 00 00 00 2c 06 40 fe 80 00 00 00 00 00 00
> 00000010: 02 02 72 ff fe c6 42 10 fe 80 00 00 00 00 00 00
> 00000020: 02 1e ab ff fe 4c 52 57
> 
> This gets compressed like this in the sending side
> 
> 00000000: 72 31 04 06 02 1e ab ff fe 4c 52 57 ec c2 00 16
> 00000010: aa 2d fe 92 86 4e be c6 ....
> 
> In the receiving end, the packet gets uncompressed to this
> IPv6 header
> 
> 00000000: 60 06 06 02 00 2a 1e 40 fe 80 00 00 00 00 00 00
> 00000010: 02 02 72 ff fe c6 42 10 fe 80 00 00 00 00 00 00
> 00000020: ab ff fe 4c 52 57 ec c2
> 
> First four bytes are set incorrectly and we have also lost
> two bytes from destination address.
> 
> The fix is to switch the case values in switch statement
> when checking the TC field.
> 
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

Applied, thanks.