From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, maze@google.com, willemb@google.com,
ycheng@google.com, stephen@networkplumber.org
Subject: Re: [PATCH] pkt_sched: fq: change classification of control packets
Date: Thu, 14 Nov 2013 17:16:59 -0500 (EST) [thread overview]
Message-ID: <20131114.171659.748664517209376981.davem@davemloft.net> (raw)
In-Reply-To: <1384447843.28716.15.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 14 Nov 2013 08:50:43 -0800
> From: Maciej Żenczykowski <maze@google.com>
>
> Initial sch_fq implementation copied code from pfifo_fast to classify
> a packet as a high prio packet.
>
> This clashes with setups using PRIO with say 7 bands, as one of the
> band could be incorrectly (mis)classified by FQ.
>
> Packets would be queued in the 'internal' queue, and no pacing ever
> happen for this special queue.
>
> Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2013-11-14 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 16:50 [PATCH] pkt_sched: fq: change classification of control packets Eric Dumazet
2013-11-14 18:58 ` [PATCH] pkt_sched: fq: fix pacing for small frames Eric Dumazet
2013-11-14 22:22 ` David Miller
2013-11-14 22:51 ` Eric Dumazet
2013-11-14 22:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114.171659.748664517209376981.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).