From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, maze@google.com, willemb@google.com,
ycheng@google.com, ncardwell@google.com
Subject: Re: [PATCH] pkt_sched: fq: fix pacing for small frames
Date: Thu, 14 Nov 2013 17:22:20 -0500 (EST) [thread overview]
Message-ID: <20131114.172220.940454781221829007.davem@davemloft.net> (raw)
In-Reply-To: <1384455496.28716.27.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 14 Nov 2013 10:58:16 -0800
> @@ -655,9 +664,6 @@ static int fq_change(struct Qdisc *sch, struct nlattr *opt)
> if (tb[TCA_FQ_INITIAL_QUANTUM])
> q->initial_quantum = nla_get_u32(tb[TCA_FQ_INITIAL_QUANTUM]);
>
> - if (tb[TCA_FQ_FLOW_DEFAULT_RATE])
> - q->flow_default_rate = nla_get_u32(tb[TCA_FQ_FLOW_DEFAULT_RATE]);
> -
> if (tb[TCA_FQ_FLOW_MAX_RATE])
> q->flow_max_rate = nla_get_u32(tb[TCA_FQ_FLOW_MAX_RATE]);
>
I think it's at best confusing to suddenly stop ignoring a configuration
parameter the user is giving us.
Can you at least ratelimit warn if the parameter is specified so the user
has some chance to figure out what is happening?
Thanks.
next prev parent reply other threads:[~2013-11-14 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 16:50 [PATCH] pkt_sched: fq: change classification of control packets Eric Dumazet
2013-11-14 18:58 ` [PATCH] pkt_sched: fq: fix pacing for small frames Eric Dumazet
2013-11-14 22:22 ` David Miller [this message]
2013-11-14 22:51 ` Eric Dumazet
2013-11-14 22:16 ` [PATCH] pkt_sched: fq: change classification of control packets David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114.172220.940454781221829007.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=maze@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).