From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: fubar@us.ibm.com, andy@greyhouse.net, nikolay@redhat.com,
vfalico@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] bonding: don't change to 802.3ad mode while ARP monitor is running
Date: Fri, 15 Nov 2013 20:40:42 -0500 (EST) [thread overview]
Message-ID: <20131115.204042.1434943107870815286.davem@davemloft.net> (raw)
In-Reply-To: <5285F12A.6030307@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Fri, 15 Nov 2013 18:02:18 +0800
> Because the ARP monitor is not support for 802.3ad, but We still
^^^^^^^
"supported"
No need to capitalize "We".
> could change the mode to 802.3ad from ab mode while ARP monirot
^^^^^^^
"monitor"
> is running, it is incorrect.
>
> So add a check for 802.3ad in bonding_store_mode to fix the problem,
> and make a micro program to simplify the code.
What is a "micro program"?
next prev parent reply other threads:[~2013-11-16 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 10:02 [PATCH net] bonding: don't change to 802.3ad mode while ARP monitor is running Ding Tianhong
2013-11-16 1:40 ` David Miller [this message]
2013-11-16 1:52 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115.204042.1434943107870815286.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).