From: David Miller <davem@davemloft.net>
To: noureddine@aristanetworks.com
Cc: dborkman@redhat.com, willemb@google.com, phil@nwl.cc,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "af-packet: Use existing netdev reference for bound sockets."
Date: Sun, 17 Nov 2013 21:28:12 -0500 (EST) [thread overview]
Message-ID: <20131117.212812.2002429039119385634.davem@davemloft.net> (raw)
In-Reply-To: <1384734522-36613-1-git-send-email-noureddine@aristanetworks.com>
From: Salam Noureddine <noureddine@aristanetworks.com>
Date: Sun, 17 Nov 2013 16:28:42 -0800
> This reverts commit 827d978037d7d0bf0860481948c6d26ead10042f.
>
> The patch introduced a race condition between packet_snd and packet_notifier
> when a net_device is being unregistered. In the case of a bound socket,
> packet_notifier can drop the last reference to the net_device and packet_snd
> might be sending a packet over a freed net_device.
You need to provide a proper "Signed-off-by: ", you need to refer to
commits not just buy SHA1 ID but also by the commit header text in
parenthesis and double quotes.
next prev parent reply other threads:[~2013-11-18 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 0:28 [PATCH] Revert "af-packet: Use existing netdev reference for bound sockets." Salam Noureddine
2013-11-18 2:28 ` David Miller [this message]
2013-11-18 5:06 ` Salam Noureddine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131117.212812.2002429039119385634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=noureddine@aristanetworks.com \
--cc=phil@nwl.cc \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).