From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: netdev@vger.kernel.org, rusty@rustcorp.com.au,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] vhost: fix the wrong log descriptions
Date: Mon, 18 Nov 2013 12:18:33 +0200 [thread overview]
Message-ID: <20131118101833.GD3559@redhat.com> (raw)
In-Reply-To: <1384744763-7476-3-git-send-email-zwu.kernel@gmail.com>
On Mon, Nov 18, 2013 at 11:19:23AM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
This one does not make sense to me.
Heads in avail ring are heads which according to Guest are available by
definition.
> ---
> drivers/vhost/vhost.c | 2 +-
> drivers/vhost/vringh.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 78987e4..568d20f 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -1241,7 +1241,7 @@ int vhost_get_vq_desc(struct vhost_dev *dev, struct vhost_virtqueue *vq,
>
> /* If their number is silly, that's an error. */
> if (unlikely(head >= vq->num)) {
> - vq_err(vq, "Guest says index %u > %u is available",
> + vq_err(vq, "Guest says index %u > %u is unavailable",
> head, vq->num);
> return -EINVAL;
> }
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index 5174eba..86ef6c4 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -57,7 +57,7 @@ static inline int __vringh_get_head(const struct vringh *vrh,
> }
>
> if (head >= vrh->vring.num) {
> - vringh_bad("Guest says index %u > %u is available",
> + vringh_bad("Guest says index %u > %u is unavailable",
> head, vrh->vring.num);
> return -EINVAL;
> }
> --
> 1.7.6.5
next prev parent reply other threads:[~2013-11-18 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 3:19 [PATCH 1/3] vhost: remove the dead branch Zhi Yong Wu
2013-11-18 3:19 ` [PATCH 2/3] vhost: adjust vhost_dev_init() to be void Zhi Yong Wu
2013-11-18 10:16 ` Michael S. Tsirkin
2013-11-18 3:19 ` [PATCH 3/3] vhost: fix the wrong log descriptions Zhi Yong Wu
2013-11-18 10:18 ` Michael S. Tsirkin [this message]
2013-11-18 13:12 ` Zhi Yong Wu
2013-11-18 10:16 ` [PATCH 1/3] vhost: remove the dead branch Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118101833.GD3559@redhat.com \
--to=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).