From: Jiri Pirko <jiri@resnulli.us>
To: Michele Baldessari <michele@acksyn.org>, netdev@vger.kernel.org
Subject: Re: oops in pskb_expand_head - 3.11.6
Date: Mon, 18 Nov 2013 23:59:45 +0100 [thread overview]
Message-ID: <20131118225945.GD3743@minipsycho.orion> (raw)
In-Reply-To: <20131118222543.GP16541@order.stressinduktion.org>
Mon, Nov 18, 2013 at 11:25:43PM CET, hannes@stressinduktion.org wrote:
>On Mon, Nov 18, 2013 at 10:24:36AM +0100, Jiri Pirko wrote:
>> Mon, Nov 18, 2013 at 10:19:22AM CET, michele@acksyn.org wrote:
>> >Hi Hannes,
>> >
>> >On Sun, Nov 17, 2013 at 08:18:10PM +0100, Hannes Frederic Sowa wrote:
>> >> On Sun, Nov 17, 2013 at 11:11:50AM +0000, Michele Baldessari wrote:
>> >> > Hi Hannes,
>> >> >
>> >> > On Sun, Nov 17, 2013 at 12:42:23AM +0100, Hannes Frederic Sowa wrote:
>> >> > > On Sat, Nov 16, 2013 at 11:16:15PM +0000, Michele Baldessari wrote:
>> >> > > > Two oops like the following were reported in Fedora 19 - kernel 3.11.6:
>> >> > > > https://bugzilla.redhat.com/show_bug.cgi?id=1015905
>> >> > >
>> >> > > I have not followed that issue that closely, but could you try linus tree
>> >> > > or net-next?
>> >> > >
>> >> > > Maybe those two patches improve the situation:
>> >> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9037c3579a277f3a23ba476664629fda8c35f7c4
>> >> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6aafeef03b9d9ecf255f3a80ed85ee070260e1ae
>> >> > >
>> >> > indeed a current kernel seems to fix the crash (according to the
>> >> > reporters). I'll see if I manage to bisect exactly.
>> >>
>> >> Great, if you confirm this we can ask David if he adds the commits to the
>> >> -stable queue.
>> >
>> >I can confirm that 6aafeef03b9d9ecf255f3a80ed85ee070260e1ae "netfilter:
>> >push reasm skb through instead of original frag skbs" fixes the oops
>> >mentioned in this thread. I've applied it to a 3.11.8 kernel and it
>> >fixed the crash. I had to slightly tweak it as it does not apply 100%
>> >cleanly due to 795aa6ef6a1aba99050735eadd0c2341b789b53b " netfilter:
>> >pass hook ops to hookfn".
>> >
>> >So definitely -stable material.
>> >
>> >Not sure if you also want to add 9037c3579a277f3a23ba476664629fda8c35f7c4
>> >"ip6_output: fragment outgoing reassembled skb properly". It did not
>> >have any impact in this particular scenario.
>>
>> It goes hand in hand with 6aafeef03b9d9ecf255f3a80ed85ee070260e1ae.
>> Without 9037c3579a277f3a23ba476664629fda8c35f7c4 skbs that reasm len is
>> < MTU would not get fragmented which is not desired.
>
>Jiri, David, do you see problems adding this to stable? We got a lot of
>reports because of exactly those kind of crashes in the past.
At this point, I do not see any reason why not to do it.
>
>Greetings,
>
> Hannes
next prev parent reply other threads:[~2013-11-18 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 23:16 oops in pskb_expand_head - 3.11.6 Michele Baldessari
2013-11-16 23:42 ` Hannes Frederic Sowa
2013-11-17 11:11 ` Michele Baldessari
2013-11-17 19:18 ` Hannes Frederic Sowa
2013-11-18 9:19 ` Michele Baldessari
2013-11-18 9:24 ` Jiri Pirko
2013-11-18 22:25 ` Hannes Frederic Sowa
2013-11-18 22:59 ` Jiri Pirko [this message]
2013-11-18 23:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118225945.GD3743@minipsycho.orion \
--to=jiri@resnulli.us \
--cc=michele@acksyn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).