From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, thaller@redhat.com,
stephen@networkplumber.org, hannes@stressinduktion.org,
vyasevich@gmail.com, dcbw@redhat.com, David.Laight@ACULAB.COM
Subject: Re: [patch net-next RFC v2 1/2] ipv6 addrconf: extend ifa_flags to u32
Date: Tue, 19 Nov 2013 16:16:53 -0500 (EST) [thread overview]
Message-ID: <20131119.161653.1620911822393300977.davem@davemloft.net> (raw)
In-Reply-To: <1384857809-6573-2-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 19 Nov 2013 11:43:28 +0100
> There is no more space in u8 ifa_flags. So do what davem suffested and
> add another netlink attr called IFA_FLAGS for carry more flags.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Thomas Haller <thaller@redhat.com>
> ---
> v1->v2:
> - reordered struct inet6_ifaddr as suggested by David Laight
> - changed flags type to u32 on couple of places as suggested by Thomas Haller
> - changed output of if6_seq_show as suggested by Thomas Haller
This looks fine, but I would suggest to extend this to all addressing
types using ifm->ifa_flags. It is not such a big deal, there are only
3 or 4.
DecNET, ipv4, ipv6, and lastly phonet (which just reports "permanent"
flag on get/dump).
That way tools like iproute2 can just generically provide and
interpret IFA_FLAGS attribute unconditionally.
next prev parent reply other threads:[~2013-11-19 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 10:43 [patch net-next RFC v2 0/2] ipv6: allow temporary address management for user-created addresses Jiri Pirko
2013-11-19 10:43 ` [patch net-next RFC v2 1/2] ipv6 addrconf: extend ifa_flags to u32 Jiri Pirko
2013-11-19 21:16 ` David Miller [this message]
2013-11-20 14:08 ` Jiri Pirko
2013-11-19 10:43 ` [patch net-next RFC v2 2/2] ipv6 addrconf: introduce IFA_F_MANAGETEMPADDR to tell kernel to manage temporary addresses Jiri Pirko
2013-11-20 16:05 ` Hannes Frederic Sowa
2013-11-20 16:18 ` Jiri Pirko
2013-11-20 16:24 ` Hannes Frederic Sowa
2013-11-27 13:02 ` Thomas Haller
2013-11-19 10:44 ` [patch iproute2 RFC v2 1/2] add support for extended ifa_flags Jiri Pirko
2013-11-19 10:44 ` [patch iproute2 RFC v2 2/2] add support for IFA_F_MANAGETEMPADDR Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119.161653.1620911822393300977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=dcbw@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=thaller@redhat.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).