From: David Miller <davem@davemloft.net>
To: vyasevic@redhat.com
Cc: netdev@vger.kernel.org, s.priebe@profihost.ag, vfalico@redhat.com
Subject: Re: [PATCH] net: core: Always propagate flag changes to interfaces
Date: Tue, 19 Nov 2013 16:24:29 -0500 (EST) [thread overview]
Message-ID: <20131119.162429.133625511390166283.davem@davemloft.net> (raw)
In-Reply-To: <1384894858-3238-1-git-send-email-vyasevic@redhat.com>
From: Vlad Yasevich <vyasevic@redhat.com>
Date: Tue, 19 Nov 2013 16:00:58 -0500
> @@ -4991,9 +4991,7 @@ static void dev_change_rx_flags(struct net_device *dev, int flags)
> {
> const struct net_device_ops *ops = dev->netdev_ops;
>
> - if (((dev->flags & IFF_UP) ||
> - (dev->flags & (IFF_MASTER | IFF_SLAVE)))
> - && ops->ndo_change_rx_flags)
> + if (ops->ndo_change_rx_flags)
> ops->ndo_change_rx_flags(dev, flags);
Right now this test looks like:
if ((dev->flags & IFF_UP) && ops->ndo_change_rx_flags)
in 'net' tree, please respin against current sources.
Thanks.
prev parent reply other threads:[~2013-11-19 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 21:00 [PATCH] net: core: Always propagate flag changes to interfaces Vlad Yasevich
2013-11-19 21:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119.162429.133625511390166283.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=s.priebe@profihost.ag \
--cc=vfalico@redhat.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).