From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/9] genetlink: clean up multicast group APIs
Date: Tue, 19 Nov 2013 16:40:34 -0500 (EST) [thread overview]
Message-ID: <20131119.164034.545622999253259387.davem@davemloft.net> (raw)
In-Reply-To: <1384870779-17571-1-git-send-email-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 19 Nov 2013 15:19:30 +0100
> The generic netlink multicast group registration doesn't have to
> be dynamic, and can thus be simplified just like I did with the
> ops. This removes some complexity in registration code.
>
> Additionally, two users of generic netlink already use multicast
> groups in a wrong way, add workarounds for those two to keep the
> userspace API working, but at the same time make them not clash
> with other users of multicast groups as might happen now.
>
> While making it all a bit easier, also prevent such abuse by adding
> checks to the APIs so each family can only use the groups it owns.
This looks great, and makes the unfortunate multicast ID handling in
DM and elsewhere explicit, controlled, and validated.
Series applied, thanks.
prev parent reply other threads:[~2013-11-19 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 14:19 [PATCH 0/9] genetlink: clean up multicast group APIs Johannes Berg
2013-11-19 14:19 ` [PATCH 1/9] genetlink: only pass array to genl_register_family_with_ops() Johannes Berg
2013-11-19 14:19 ` [PATCH 2/9] drop_monitor/genetlink: use proper genetlink multicast APIs Johannes Berg
2013-11-19 14:19 ` [PATCH 3/9] quota/genetlink: " Johannes Berg
2013-11-19 14:19 ` [PATCH 4/9] hsr: don't call genl_unregister_mc_group() Johannes Berg
2013-11-19 14:19 ` [PATCH 5/9] genetlink: remove genl_unregister_mc_group() Johannes Berg
2013-11-19 14:19 ` [PATCH 6/9] genetlink: remove family pointer from genl_multicast_group Johannes Berg
2013-11-19 14:19 ` [PATCH 7/9] genetlink: add and use genl_set_err() Johannes Berg
2013-11-19 14:19 ` [PATCH 8/9] genetlink: pass family to functions using groups Johannes Berg
2013-11-19 14:19 ` [PATCH 9/9] genetlink: make multicast groups const, prevent abuse Johannes Berg
2013-11-19 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119.164034.545622999253259387.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).