Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: freddy@asix.com.tw
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, davemloft@davemloft.net,
	louis@asix.com.tw, allan@asix.com.tw, grundler@google.com,
	daniel@asix.com.tw
Subject: Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS
Date: Wed, 20 Nov 2013 00:40:26 -0500 (EST)	[thread overview]
Message-ID: <20131120.004026.2013972041095203460.davem@davemloft.net> (raw)
In-Reply-To: <1384913496-26261-1-git-send-email-freddy@asix.com.tw>

From: freddy@asix.com.tw
Date: Wed, 20 Nov 2013 10:11:36 +0800

> From: Freddy Xin <freddy@asix.com.tw>
> 
> This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns
> off its Ethernet PHY power in the case that REMOTE_WAKEUP feature doesn't
> be set when system suspend. In this case, the PHY power will not be turned
> on again when system resume, so the HW reset must be added in the resume function.
> 
> Signed-off-by: Freddy Xin <freddy@asix.com.tw>
> Tested-by: Grant Grundler <grundler@chromium.org>

Like many similar patches I've seen recently, you cannot do this.

Now the the configuration that software things the PHY has is no
longer accurate.

If you absolutely must reset the chip on resume, you have to reprogram
the PHY with whatever settings were existed at the time of the suspend.

  reply	other threads:[~2013-11-20  5:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  2:11 [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS freddy-knRN6Y/kmf1NUHwG+Fw1Kw
2013-11-20  5:40 ` David Miller [this message]
2013-11-20 17:42   ` Grant Grundler
2013-11-20 18:54     ` David Miller
2013-11-20 19:32       ` Grant Grundler
2013-11-21 22:48         ` Grant Grundler
2013-11-22  1:58           ` Florian Fainelli
     [not found]             ` <CAGVrzcase25NosVHA74OLnviJj7nU_2Rxki_hvi8bOwznDuWGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-22  2:26               ` Grant Grundler
2013-11-22  2:42                 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131120.004026.2013972041095203460.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=allan@asix.com.tw \
    --cc=daniel@asix.com.tw \
    --cc=davemloft@davemloft.net \
    --cc=freddy@asix.com.tw \
    --cc=grundler@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=louis@asix.com.tw \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox