From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com, hkchu@google.com
Subject: Re: Get rxhash fixes and RFS support in tun
Date: Wed, 20 Nov 2013 21:23:21 -0500 (EST) [thread overview]
Message-ID: <20131120.212321.700376819925646003.davem@davemloft.net> (raw)
In-Reply-To: <CA+mtBx91hSmYKrbUsPrtnXRjYR8QDGZ+GAAnMixauUqw9LFkiQ@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Wed, 20 Nov 2013 17:09:01 -0800
> I think the sw_rxhash holds more useful information. In
> skb_get_rxhash() either we have an L4 hash or we try to get one by
> doing the SW computation, this means we don't ever return a HW hash
> which is not L4 so basically that case is treated as an invalid hash.
> So after a call to skb_get_rxhash, at least one of l4_rxhash or
> sw_rxhash is and we won't redo flow dissection on subsequent calls
> unless the rxhash is cleared.
Ok.... one interesting issue remains, which is that the SW flow
dissector considers decapsulating protocols like AH and ESP as
"L4".
I think we'll need to do something about that at some point.
next prev parent reply other threads:[~2013-11-21 2:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 20:25 Get rxhash fixes and RFS support in tun Tom Herbert
2013-11-21 0:02 ` David Miller
2013-11-21 1:09 ` Tom Herbert
2013-11-21 1:12 ` Stephen Hemminger
2013-11-21 2:23 ` David Miller [this message]
2013-11-21 2:42 ` Tom Herbert
2013-11-21 2:50 ` David Miller
2013-11-21 16:28 ` Tom Herbert
2013-11-21 18:03 ` David Miller
2013-11-21 5:03 ` Jason Wang
2013-11-22 20:09 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120.212321.700376819925646003.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).