From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH net 1/3] virtio-net: drop the rest of buffers when we
	can't allocate skb
Date: Wed, 20 Nov 2013 15:27:29 +0200
Message-ID: <20131120132729.GB8455@redhat.com>
References: <1384938447-3775-1-git-send-email-jasowang@redhat.com>
	<20131120103406.GF19341@redhat.com>
	<1146110853.27426099.1384949282266.JavaMail.root@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: Michael Dalton <mwdalton@google.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org,
	Eric Dumazet <edumazet@google.com>, Shirley Ma <xma@us.ibm.com>
To: Jason Wang <jasowang@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <1146110853.27426099.1384949282266.JavaMail.root@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

T24gV2VkLCBOb3YgMjAsIDIwMTMgYXQgMDc6MDg6MDJBTSAtMDUwMCwgSmFzb24gV2FuZyB3cm90
ZToKPiAKPiAKPiAtLS0tLSDljp/lp4vpgq7ku7YgLS0tLS0KPiA+IE9uIFdlZCwgTm92IDIwLCAy
MDEzIGF0IDA1OjA3OjI1UE0gKzA4MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+IFdoZW4gbWVy
Z2VhYmxlIGJ1ZmZlciB3ZXJlIHVzZWQsIHdlIG9ubHkgcHV0IHRoZSBmaXJzdCBwYWdlIGJ1ZiBs
ZWF2ZSB0aGUKPiA+ID4gcmVzdAo+ID4gPiBvZiBidWZmZXJzIGluIHRoZSB2aXJ0IHF1ZXVlLiBU
aGlzIHdpbGwgY2F1c2UgdGhlIGRyaXZlciBjb3VsZCBub3QgZ2V0IHRoZQo+ID4gPiBjb3JyZWN0
IGhlYWQgYnVmZmVyIGFueSBtb3JlLiBGaXggdGhpcyBieSBkcm9wcGluZyB0aGUgcmVzdCBvZiBi
dWZmZXJzIGZvcgo+ID4gPiB0aGlzCj4gPiA+IHBhY2tldC4KPiA+ID4gCj4gPiA+IFRoZSBidWcg
d2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDlhYjg2YmJjZjhiZTc1NTI1NmYwYTVlOTk0ZTBiMzhh
ZjZiNGQzOTkKPiA+ID4gKHZpcnRpb19uZXQ6IERlZmVyIHNrYiBhbGxvY2F0aW9uIGluIHJlY2Vp
dmUgcGF0aCkuCj4gPiA+IAo+ID4gPiBDYzogUnVzdHkgUnVzc2VsbCA8cnVzdHlAcnVzdGNvcnAu
Y29tLmF1Pgo+ID4gPiBDYzogTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT4KPiA+
ID4gQ2M6IE1pY2hhZWwgRGFsdG9uIDxtd2RhbHRvbkBnb29nbGUuY29tPgo+ID4gPiBDYzogRXJp
YyBEdW1hemV0IDxlZHVtYXpldEBnb29nbGUuY29tPgo+ID4gPiBDYzogU2hpcmxleSBNYSA8eG1h
QHVzLmlibS5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJl
ZGhhdC5jb20+Cj4gPiA+IC0tLQo+ID4gPiBUaGlzIHBhdGNoIHdhcyBuZWVkZWQgZm9yIHN0YWJs
ZQo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDE4ICsrKysrKysr
KysrKysrKysrLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEgZGVs
ZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0
LmMgYi9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiA+ID4gaW5kZXggN2JhYjRkZS4uMjRmZDUw
MiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiA+ICsrKyBi
L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gPiBAQCAtMjIyLDYgKzIyMiwxNyBAQCBzdGF0
aWMgdm9pZCBza2JfeG1pdF9kb25lKHN0cnVjdCB2aXJ0cXVldWUgKnZxKQo+ID4gPiAgCW5ldGlm
X3dha2Vfc3VicXVldWUodmktPmRldiwgdnEydHhxKHZxKSk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+
ID4gK3N0YXRpYyB2b2lkIGRyb3BfbWVyZ2VhYmxlX2J1ZmZlcihzdHJ1Y3QgcmVjZWl2ZV9xdWV1
ZSAqcnEsIGludCBudW1fYnVmKQo+ID4gPiArewo+ID4gPiArCWNoYXIgKmJ1ZjsKPiA+ID4gKwlp
bnQgbGVuOwo+ID4gPiArCj4gPiA+ICsJd2hpbGUgKC0tbnVtX2J1ZiAmJiAoYnVmID0gdmlydHF1
ZXVlX2dldF9idWYocnEtPnZxLCAmbGVuKSkgIT0gTlVMTCkgewo+ID4gPiArCQktLXJxLT5udW07
Cj4gPiA+ICsJCXB1dF9wYWdlKHZpcnRfdG9faGVhZF9wYWdlKGJ1ZikpOwo+ID4gPiArCX0KPiA+
ID4gK30KPiA+ID4gKwo+ID4gCj4gPiBUaGlzIGlzIHRoZSBzYW1lIGNvZGUgd2UgaGF2ZSBpbiBy
ZWNlaXZlX21lcmdlYWJsZSBhbnl3YXkuCj4gPiBTbyBsZXQncyByZXVzZSB0aGF0Lgo+ID4gCj4g
PiAKPiAKPiByZWNlaXZlX21lcmdlYWJsZSgpIHdhcyBjYWxsZWQgYWZ0ZXIgcGFnZV90b19za2Io
KSB3YXMgY2FsbGVkIGFuZCAKPiB0aGVyZSdzIGxvdHMgb2YgY29uZGl0aW9ucyBjaGVjayB0aGVy
ZS4gSSdtIG5vdCBzdXJlIGhvdyBjb3VsZCB3ZSAKPiByZXVzZSB0aGVtLgoKSSBwb3N0ZWQgYSBw
YXRjaCBzaG93aW5nIGhvdyA6KQoKPiA+ID4gIC8qIENhbGxlZCBmcm9tIGJvdHRvbSBoYWxmIGNv
bnRleHQgKi8KPiA+ID4gIHN0YXRpYyBzdHJ1Y3Qgc2tfYnVmZiAqcGFnZV90b19za2Ioc3RydWN0
IHJlY2VpdmVfcXVldWUgKnJxLAo+ID4gPiAgCQkJCSAgIHN0cnVjdCBwYWdlICpwYWdlLCB1bnNp
Z25lZCBpbnQgb2Zmc2V0LAo+ID4gPiBAQCAtMjM3LDggKzI0OCwxMyBAQCBzdGF0aWMgc3RydWN0
IHNrX2J1ZmYgKnBhZ2VfdG9fc2tiKHN0cnVjdAo+ID4gPiByZWNlaXZlX3F1ZXVlICpycSwKPiA+
ID4gIAo+ID4gPiAgCS8qIGNvcHkgc21hbGwgcGFja2V0IHNvIHdlIGNhbiByZXVzZSB0aGVzZSBw
YWdlcyBmb3Igc21hbGwgZGF0YSAqLwo+ID4gPiAgCXNrYiA9IG5ldGRldl9hbGxvY19za2JfaXBf
YWxpZ24odmktPmRldiwgR09PRF9DT1BZX0xFTik7Cj4gPiA+IC0JaWYgKHVubGlrZWx5KCFza2Ip
KQo+ID4gPiArCWlmICh1bmxpa2VseSghc2tiKSkgewo+ID4gPiArCQlpZiAodmktPm1lcmdlYWJs
ZV9yeF9idWZzKSB7Cj4gPiA+ICsJCQloZHIgPSAoc3RydWN0IHNrYl92bmV0X2hkciAqKXA7Cj4g
PiA+ICsJCQlkcm9wX21lcmdlYWJsZV9idWZmZXIocnEsIGhkci0+bWhkci5udW1fYnVmZmVycyk7
Cj4gPiA+ICsJCX0KPiA+ID4gIAkJcmV0dXJuIE5VTEw7Cj4gPiA+ICsJfQo+ID4gPiAgCj4gPiA+
ICAJaGRyID0gc2tiX3ZuZXRfaGRyKHNrYik7Cj4gPiA+ICAKPiA+ID4gLS0KPiA+ID4gMS44LjMu
Mgo+ID4gLS0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l
ICJ1bnN1YnNjcmliZSBsaW51eC1rZXJuZWwiIGluCj4gPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2Ug
dG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+ID4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAg
aHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gPiBQbGVhc2UgcmVh
ZCB0aGUgRkFRIGF0ICBodHRwOi8vd3d3LnR1eC5vcmcvbGttbC8KPiA+IApfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5n
IGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9s
aXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=