From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH net 2/3] virtio-net: fix num calculation on frag skb
	allocation failure
Date: Wed, 20 Nov 2013 15:37:07 +0200
Message-ID: <20131120133707.GA8523@redhat.com>
References: <1384938447-3775-1-git-send-email-jasowang@redhat.com>
	<1384938447-3775-2-git-send-email-jasowang@redhat.com>
	<20131120103729.GG19341@redhat.com>
	<734327384.27426189.1384949330819.JavaMail.root@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: Michael Dalton <mwdalton@google.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org,
	Eric Dumazet <edumazet@google.com>
To: Jason Wang <jasowang@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <734327384.27426189.1384949330819.JavaMail.root@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

T24gV2VkLCBOb3YgMjAsIDIwMTMgYXQgMDc6MDg6NTBBTSAtMDUwMCwgSmFzb24gV2FuZyB3cm90
ZToKPiAKPiAKPiAtLS0tLSDljp/lp4vpgq7ku7YgLS0tLS0KPiA+IE9uIFdlZCwgTm92IDIwLCAy
MDEzIGF0IDA1OjA3OjI2UE0gKzA4MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+IFdlIG5lZWQg
ZGVjcmVhc2UgdGhlIHJxLT5udW0gYWZ0ZXIgd2UgY2FuIGdldCBhIGJ1ZiB0aHJvdWdoCj4gPiA+
IHZpcnRxdWV1ZV9nZXRfYnVmKCkgZXZlbiBpZiB3ZSBjb3VsZCBub3QgYWxsb2NhdGUgZnJhZyBz
a2IuIE90aGVyd2lzZSwgdGhlCj4gPiA+IHJlZmlsbCByb3V0aW5lIHdvbid0IGJlIHRyaWdnZXJl
ZCB1bmRlciBoZWF2eSBtZW1vcnkgc3RyZXNzIHNpbmNlIHRoZQo+ID4gPiBkcml2ZXIgbWF5Cj4g
PiA+IHN0aWxsIHRoaW5rIHRoZXJlJ3MgZW5vdWdoIHJvb20uCj4gPiA+IAo+ID4gPiBUaGlzIGJ1
ZyB3YXMgaW50cm9kdWNlZCBieSBjb21taXQgMjYxM2FmMGVkMThhMTFkNWM1NjZhODFmOWE2NTEw
YjczMTgwNjYwYQo+ID4gPiAodmlydGlvX25ldDogbWlncmF0ZSBtZXJnZWFibGUgcnggYnVmZmVy
cyB0byBwYWdlIGZyYWcgYWxsb2NhdG9ycykuCj4gPiA+IAo+ID4gPiBDYzogUnVzdHkgUnVzc2Vs
bCA8cnVzdHlAcnVzdGNvcnAuY29tLmF1Pgo+ID4gPiBDYzogTWljaGFlbCBTLiBUc2lya2luIDxt
c3RAcmVkaGF0LmNvbT4KPiA+ID4gQ2M6IE1pY2hhZWwgRGFsdG9uIDxtd2RhbHRvbkBnb29nbGUu
Y29tPgo+ID4gPiBDYzogRXJpYyBEdW1hemV0IDxlZHVtYXpldEBnb29nbGUuY29tPgo+ID4gPiBT
aWduZWQtb2ZmLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+ID4gCj4gPiBT
byBsZXQncyB3cmFwIHZpcnRxdWV1ZV9nZXRfYnVmIHRvIG1ha2Ugc3VyZSB3ZSBnZXQgaXQgcmln
aHQ/Cj4gPiAKPiAKPiBPay4gZ29vZCBpZGVhLgoKU28gSSBkaWQgdGhpcyAoYmVsb3cpIGJ1dCB0
aGUgY29tcGlsZXIgaXMgbm90IHNtYXJ0IGVub3VnaCB0bwphdm9pZCB0d28gYnJhbmNoZXMgb24g
ZGF0YSBwYXRoLgpTbyBJJ20gbm90IHN1cmUgYW55bW9yZTogd2l0aCBteSBwYXRjaCBpdCdzIHBy
ZXR0eSBjbGVhciBob3cKdGhlIGNvZGUgd29ya3MuCgpTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIFMu
IFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgoKYnV0IEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0byBh
cHBseSB0aGlzLgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBiL2RyaXZl
cnMvbmV0L3ZpcnRpb19uZXQuYwppbmRleCAxMWQ5Y2M5Li4xY2MyZTQzIDEwMDY0NAotLS0gYS9k
cml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCkBA
IC0yOTYsNiArMjk2LDE0IEBAIHN0YXRpYyBzdHJ1Y3Qgc2tfYnVmZiAqcGFnZV90b19za2Ioc3Ry
dWN0IHJlY2VpdmVfcXVldWUgKnJxLAogCXJldHVybiBza2I7CiB9CiAKK3N0YXRpYyB2b2lkICpy
cV9nZXRfYnVmKHN0cnVjdCByZWNlaXZlX3F1ZXVlICpycSwgdW5zaWduZWQgaW50ICpsZW4pCit7
CisJdm9pZCAqYnVmID0gdmlydHF1ZXVlX2dldF9idWYocnEtPnZxLCBsZW4pOworCWlmIChidWYp
CisJCXJxLT5udW0tLTsKKwlyZXR1cm4gYnVmOworfQorCiBzdGF0aWMgc3RydWN0IHNrX2J1ZmYg
KnJlY2VpdmVfbWVyZ2VhYmxlKHN0cnVjdCBuZXRfZGV2aWNlICpkZXYsCiAJCQkJCSBzdHJ1Y3Qg
cmVjZWl2ZV9xdWV1ZSAqcnEsCiAJCQkJCSB2b2lkICpidWYsCkBAIC0zMTUsNyArMzIzLDcgQEAg
c3RhdGljIHN0cnVjdCBza19idWZmICpyZWNlaXZlX21lcmdlYWJsZShzdHJ1Y3QgbmV0X2Rldmlj
ZSAqZGV2LAogCXdoaWxlICgtLW51bV9idWYpIHsKIAkJaW50IG51bV9za2JfZnJhZ3M7CiAKLQkJ
YnVmID0gdmlydHF1ZXVlX2dldF9idWYocnEtPnZxLCAmbGVuKTsKKwkJYnVmID0gcnFfZ2V0X2J1
ZihycSwgJmxlbik7CiAJCWlmICh1bmxpa2VseSghYnVmKSkgewogCQkJcHJfZGVidWcoIiVzOiBy
eCBlcnJvcjogJWQgYnVmZmVycyBvdXQgb2YgJWQgbWlzc2luZ1xuIiwKIAkJCQkgZGV2LT5uYW1l
LCBudW1fYnVmLCBoZHItPm1oZHIubnVtX2J1ZmZlcnMpOwpAQCAtMzI5LDcgKzMzNyw2IEBAIHN0
YXRpYyBzdHJ1Y3Qgc2tfYnVmZiAqcmVjZWl2ZV9tZXJnZWFibGUoc3RydWN0IG5ldF9kZXZpY2Ug
KmRldiwKIAkJfQogCiAJCXBhZ2UgPSB2aXJ0X3RvX2hlYWRfcGFnZShidWYpOwotCQktLXJxLT5u
dW07CiAKIAkJbnVtX3NrYl9mcmFncyA9IHNrYl9zaGluZm8oY3Vycl9za2IpLT5ucl9mcmFnczsK
IAkJaWYgKHVubGlrZWx5KG51bV9za2JfZnJhZ3MgPT0gTUFYX1NLQl9GUkFHUykpIHsKQEAgLTM3
MCw3ICszNzcsNyBAQCBlcnJfYnVmOgogCWRldi0+c3RhdHMucnhfZHJvcHBlZCsrOwogCWRldl9r
ZnJlZV9za2IoaGVhZF9za2IpOwogCXdoaWxlICgtLW51bV9idWYpIHsKLQkJYnVmID0gdmlydHF1
ZXVlX2dldF9idWYocnEtPnZxLCAmbGVuKTsKKwkJYnVmID0gcnFfZ2V0X2J1ZihycSwgJmxlbik7
CiAJCWlmICh1bmxpa2VseSghYnVmKSkgewogCQkJcHJfZGVidWcoIiVzOiByeCBlcnJvcjogJWQg
YnVmZmVycyBtaXNzaW5nXG4iLAogCQkJCSBkZXYtPm5hbWUsIG51bV9idWYpOwpAQCAtMzc5LDcg
KzM4Niw2IEBAIGVycl9idWY6CiAJCX0KIAkJcGFnZSA9IHZpcnRfdG9faGVhZF9wYWdlKGJ1Zik7
CiAJCXB1dF9wYWdlKHBhZ2UpOwotCQktLXJxLT5udW07CiAJfQogCXJldHVybiBOVUxMOwogfQpA
QCAtNjc1LDkgKzY4MSw4IEBAIHN0YXRpYyBpbnQgdmlydG5ldF9wb2xsKHN0cnVjdCBuYXBpX3N0
cnVjdCAqbmFwaSwgaW50IGJ1ZGdldCkKIAogYWdhaW46CiAJd2hpbGUgKHJlY2VpdmVkIDwgYnVk
Z2V0ICYmCi0JICAgICAgIChidWYgPSB2aXJ0cXVldWVfZ2V0X2J1ZihycS0+dnEsICZsZW4pKSAh
PSBOVUxMKSB7CisJICAgICAgIChidWYgPSBycV9nZXRfYnVmKHJxLCAmbGVuKSkgIT0gTlVMTCkg
ewogCQlyZWNlaXZlX2J1ZihycSwgYnVmLCBsZW4pOwotCQktLXJxLT5udW07CiAJCXJlY2VpdmVk
Kys7CiAJfQogCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
ClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1m
b3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9s
aXN0aW5mby92aXJ0dWFsaXphdGlvbg==