From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, johannes.berg@intel.com
Subject: Re: [PATCH] genetlink: fix genlmsg_multicast() bug
Date: Thu, 21 Nov 2013 13:18:09 -0500 (EST) [thread overview]
Message-ID: <20131121.131809.935111586164423904.davem@davemloft.net> (raw)
In-Reply-To: <1385054224-1410-1-git-send-email-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 21 Nov 2013 18:17:04 +0100
> From: Johannes Berg <johannes.berg@intel.com>
>
> Unfortunately, I introduced a tremendously stupid bug into
> genlmsg_multicast() when doing all those multicast group
> changes: it adjusts the group number, but then passes it
> to genlmsg_multicast_netns() which does that again.
>
> Somehow, my tests failed to catch this, so add a warning
> into genlmsg_multicast_netns() and remove the offending
> group ID adjustment.
>
> Also add a warning to the similar code in other functions
> so people who misuse them are more loudly warned.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied.
prev parent reply other threads:[~2013-11-21 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 17:17 [PATCH] genetlink: fix genlmsg_multicast() bug Johannes Berg
2013-11-21 18:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121.131809.935111586164423904.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox