From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCHv1 net] xen-netback: stop the VIF thread before unbinding IRQs Date: Thu, 21 Nov 2013 15:50:31 +0000 Message-ID: <20131121155031.GA30889@zion.uk.xensource.com> References: <1385047569-23622-1-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , Konrad Rzeszutek Wilk , Boris Ostrovsky , Ian Campbell , Wei Liu , To: David Vrabel Return-path: Received: from smtp.citrix.com ([66.165.176.89]:11607 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116Ab3KUPuc (ORCPT ); Thu, 21 Nov 2013 10:50:32 -0500 Content-Disposition: inline In-Reply-To: <1385047569-23622-1-git-send-email-david.vrabel@citrix.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 21, 2013 at 03:26:09PM +0000, David Vrabel wrote: > From: David Vrabel > > If the VIF thread is still running after unbinding the Tx and Rx IRQs > in xenvif_disconnect(), the thread may attempt to raise an event which > will BUG (as the irq is unbound). > > Signed-off-by: David Vrabel Acked-by: Wei Liu Thanks Wei. > --- > drivers/net/xen-netback/interface.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index b78ee10..2329ccc 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -461,6 +461,9 @@ void xenvif_disconnect(struct xenvif *vif) > if (netif_carrier_ok(vif->dev)) > xenvif_carrier_off(vif); > > + if (vif->task) > + kthread_stop(vif->task); > + > if (vif->tx_irq) { > if (vif->tx_irq == vif->rx_irq) > unbind_from_irqhandler(vif->tx_irq, vif); > @@ -471,9 +474,6 @@ void xenvif_disconnect(struct xenvif *vif) > vif->tx_irq = 0; > } > > - if (vif->task) > - kthread_stop(vif->task); > - > xenvif_unmap_frontend_rings(vif); > } > > -- > 1.7.2.5 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html