From: Thomas Graf <tgraf@suug.ch>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: jesse@nicira.com, davem@davemloft.net, dev@openvswitch.org,
netdev@vger.kernel.org, dborkman@redhat.com, ffusco@redhat.com,
fleitner@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath
Date: Thu, 21 Nov 2013 22:20:47 +0000 [thread overview]
Message-ID: <20131121222047.GA14252@casper.infradead.org> (raw)
In-Reply-To: <1385058197.1586.15.camel@bwh-desktop.uk.level5networks.com>
On 11/21/13 at 06:23pm, Ben Hutchings wrote:
> On Thu, 2013-11-21 at 19:13 +0100, Thomas Graf wrote:
> > +
> > +/**
> > + * V2:
>
> This is not kernel-doc format so don't use '/**'.
I was hoping kernel-doc would pick it up but it doesn't.
I'll convert it.
> > + if (info->genlhdr->version < OVS_DP_VER_FEATURES) {
> > + WARN_ONCE(dp->user_features, "Dropping previously "
> > + "announced user features");
>
> Log messages shouldn't be split like this as it makes them harder to
> find. There should also be a newline at the end of the message.
Right, I'll fix this up. We seem to have many of these unfixed.
Jesse, do you want a full respin or just a v2 of this patch?
next prev parent reply other threads:[~2013-11-21 22:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 18:13 [PATCH net-next 0/8 v6] Open vSwitch upcall optimiziations Thomas Graf
[not found] ` <cover.1385057355.git.tgraf-G/eBtMaohhA@public.gmane.org>
2013-11-21 18:13 ` [PATCH net-next 1/8] genl: Add genlmsg_new_unicast() for unicast message allocation Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 2/8] netlink: Avoid netlink mmap alloc if msg size exceeds frame size Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 3/8] openvswitch: Enable memory mapped Netlink i/o Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 4/8] net: Export skb_zerocopy() to zerocopy from one skb to another Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 5/8] openvswitch: Allow user space to announce ability to accept unaligned Netlink messages Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 6/8] openvswitch: Allow update of dp with OVS_DP_CMD_NEW if NLM_F_REPLACE is set Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath Thomas Graf
2013-11-21 18:23 ` Ben Hutchings
2013-11-21 22:20 ` Thomas Graf [this message]
2013-11-21 23:50 ` Jesse Gross
2013-11-21 18:13 ` [PATCH net-next 8/8] openvswitch: Use skb_zerocopy() for upcall Thomas Graf
-- strict thread matches above, loose matches on Subject: below --
2013-11-22 16:56 [PATCH net-next 0/8 v7] Open vSwitch upcall optimiziations Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath Thomas Graf
2013-11-25 23:40 ` Jesse Gross
2013-11-27 22:35 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121222047.GA14252@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=eric.dumazet@gmail.com \
--cc=ffusco@redhat.com \
--cc=fleitner@redhat.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).