From: David Miller <davem@davemloft.net>
To: vyasevich@gmail.com
Cc: changxiangzhong@gmail.com, nhorman@tuxdriver.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sctp: find the correct highest_new_tsn in sack
Date: Sat, 23 Nov 2013 14:46:57 -0800 (PST) [thread overview]
Message-ID: <20131123.144657.1317547893471212174.davem@davemloft.net> (raw)
In-Reply-To: <528E85A9.3000703@gmail.com>
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Thu, 21 Nov 2013 17:14:01 -0500
> On 11/21/2013 04:56 PM, Chang Xiangzhong wrote:
>> Function sctp_check_transmitted(transport t, ...) would iterate all of
>> transport->transmitted queue and looking for the highest __newly__ acked tsn.
>> The original algorithm would depend on the order of the assoc->transport_list
>> (in function sctp_outq_sack line 1215 - 1226). The result might not be the
>> expected due to the order of the tranport_list.
>>
>> Solution: checking if the exising is smaller than the new one before assigning
>>
>> Signed-off-by: Chang Xiangzhong <changxiangzhong@gmail.com>
>
> Good find. This has been around for since day 1. It doesn't so much
> depend on the order of the transport list, but on the order the
> transports been used. I agree it is a problem if chunks have been
> distributed across multiple transports and a singe SACK acking them all.
>
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2013-11-23 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 21:56 [PATCH] net: sctp: find the correct highest_new_tsn in sack Chang Xiangzhong
2013-11-21 22:14 ` Vlad Yasevich
2013-11-23 22:46 ` David Miller [this message]
2013-11-22 11:56 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123.144657.1317547893471212174.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=changxiangzhong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).