From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: yangyingliang@huawei.com, netdev@vger.kernel.org,
ben@decadent.org.uk, jpirko@redhat.com, jhs@mojatatu.com
Subject: Re: [PATCH] sch_tbf: handle too small burst
Date: Sat, 23 Nov 2013 14:49:33 -0800 (PST) [thread overview]
Message-ID: <20131123.144933.671852794341688223.davem@davemloft.net> (raw)
In-Reply-To: <1385240360.10637.108.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 23 Nov 2013 12:59:20 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> If a too small burst is inadvertently set on TBF, we might trigger
> a bug in tbf_segment(), as 'skb' instead of 'segs' was used in a
> qdisc_reshape_fail() call.
>
> tc qdisc add dev eth0 root handle 1: tbf latency 50ms burst 1KB rate
> 50mbit
>
> Fix the bug, and add a warning, as such configuration is not
> going to work anyway for non GSO packets.
>
> (For some reason, one has to use a burst >= 1520 to get a working
> configuration, even with old kernels. This is a probable iproute2/tc
> bug)
>
> Based on a report and initial patch from Yang Yingliang
>
> Fixes: e43ac79a4bc6 ("sch_tbf: segment too big GSO packets")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Yang Yingliang <yangyingliang@huawei.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2013-11-23 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 9:27 [PATCH] net: sched: tbf: fix an oops when a GSO packet cannot be enqueued Yang Yingliang
2013-11-22 14:50 ` Eric Dumazet
2013-11-23 8:08 ` Yang Yingliang
2013-11-23 17:56 ` Eric Dumazet
2013-11-23 20:59 ` [PATCH] sch_tbf: handle too small burst Eric Dumazet
2013-11-23 22:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123.144933.671852794341688223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).