From: Jean Delvare <khali@linux-fr.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Nithin Nayak Sujir <nsujir@broadcom.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Michael Chan <mchan@broadcom.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
lm-sensors@lm-sensors.org, Greg Rose <gregory.v.rose@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [lm-sensors] [PATCH 0/5] net: hwmon fixes
Date: Mon, 25 Nov 2013 19:23:34 +0100 [thread overview]
Message-ID: <20131125192334.580400ef@endymion.delvare> (raw)
In-Reply-To: <1385399750.1586.40.camel@bwh-desktop.uk.level5networks.com>
On Mon, 25 Nov 2013 17:15:50 +0000, Ben Hutchings wrote:
> On Sat, 2013-11-23 at 09:07 -0800, Guenter Roeck wrote:
> > Yes, I know about that one. It concluded that it would be too invasive
> > and risky to try to fix it without access to hardware to test the results.
> > That is why I said "fixes _most_ of the problems".
> >
> > As for why the attributes are created after registration, it was most likely
> > because there was no API available to attach the sysfs attributes to
> > the hwmon device in a clean way. The new APIs fix that.
>
> We don't attach them to the hwmon device either, and I would rather not
> change that yet because lm-sensors 2 is still widely used.
Mouahahahah.
No, seriously, it's not. And lm-sensors 2 doesn't even support your
device so this is a totally moot point.
--
Jean Delvare
next prev parent reply other threads:[~2013-11-25 18:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 6:07 [PATCH 0/5] net: hwmon fixes Guenter Roeck
2013-11-23 6:07 ` [PATCH 1/5] tg3: Convert to use hwmon_device_register_with_groups Guenter Roeck
2013-11-23 14:32 ` [lm-sensors] " Jean Delvare
2013-11-26 1:52 ` Nithin Nayak Sujir
2013-11-26 2:47 ` Guenter Roeck
2013-11-26 17:50 ` Nithin Nayak Sujir
2013-11-28 23:22 ` David Miller
2013-11-23 6:07 ` [PATCH 2/5] igb: Convert to use devm_hwmon_device_register_with_groups Guenter Roeck
2013-11-25 23:16 ` Jeff Kirsher
2013-11-23 6:07 ` [PATCH 3/5] ixgbe: " Guenter Roeck
2013-11-25 23:17 ` Jeff Kirsher
2013-11-23 6:08 ` [PATCH 4/5] igb: Start temperature sensor attribute index with 1 Guenter Roeck
2013-11-23 12:58 ` [lm-sensors] " Jean Delvare
2013-11-25 23:17 ` Jeff Kirsher
2013-11-23 6:08 ` [PATCH 5/5] ixgbe: " Guenter Roeck
2013-11-23 13:01 ` [lm-sensors] " Jean Delvare
2013-11-25 18:08 ` Guenter Roeck
2013-11-25 23:18 ` Jeff Kirsher
2013-11-23 16:48 ` [PATCH 0/5] net: hwmon fixes Ben Hutchings
2013-11-23 17:07 ` Guenter Roeck
2013-11-25 17:15 ` Ben Hutchings
2013-11-25 17:48 ` Guenter Roeck
2013-11-26 20:08 ` Ben Hutchings
2013-11-27 3:28 ` Guenter Roeck
2013-11-25 18:23 ` Jean Delvare [this message]
2013-11-25 18:56 ` [lm-sensors] " Ben Hutchings
2013-11-25 19:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125192334.580400ef@endymion.delvare \
--to=khali@linux-fr.org \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox