From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH] net: smc91: fix crash regression on the versatile
Date: Wed, 27 Nov 2013 12:13:03 +0000
Message-ID: <20131127121303.GM16735@n2100.arm.linux.org.uk>
References: <1385553099-13874-1-git-send-email-linus.walleij@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Miao <eric.y.miao@gmail.com>,
	Jonathan Cameron <jic23@cam.ac.uk>, stable@vger.kernel.org
To: Linus Walleij <linus.walleij@linaro.org>
Return-path: <stable-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1385553099-13874-1-git-send-email-linus.walleij@linaro.org>
Sender: stable-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Wed, Nov 27, 2013 at 12:51:39PM +0100, Linus Walleij wrote:
> This is because the macro operations in smc91x.h are missing
> necessary #defines for operations such as SMC_inbsw(),
> SMC_outsw() and SMC_outsb() making these defined to BUG().
> 
> The Versatile needs and uses the same accessors as the other
> platforms in the first if(...) clause, just switch it to using
> that and we have one problem less to worry about.
> 
> This bug seems to have been around for some quite time, just
> that few people test the Versatile on real hardware, and it
> compiles.

That's a misconception.  This bug is caused by:

commit e9e4ea74f06635f2ffc1dffe5ef40c854faa0a90
Author: Will Deacon <will.deacon@arm.com>
Date:   Fri Oct 11 14:52:20 2013 +0100

    net: smc91x: dont't use SMC_outw for fixing up halfword-aligned data