From: Thomas Graf <tgraf@suug.ch>
To: Jesse Gross <jesse@nicira.com>
Cc: David Miller <davem@davemloft.net>,
"dev@openvswitch.org" <dev@openvswitch.org>,
netdev <netdev@vger.kernel.org>,
Daniel Borkmann <dborkman@redhat.com>,
ffusco@redhat.com, fleitner@redhat.com,
Eric Dumazet <eric.dumazet@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath
Date: Wed, 27 Nov 2013 22:35:12 +0000 [thread overview]
Message-ID: <20131127223512.GB26084@casper.infradead.org> (raw)
In-Reply-To: <CAEP_g=8nADwqAJ81gtpJ-6v2XW4Se+OK1RPcEZ7mh-_PAwyo7g@mail.gmail.com>
On 11/25/13 at 03:40pm, Jesse Gross wrote:
> On Fri, Nov 22, 2013 at 8:56 AM, Thomas Graf <tgraf@suug.ch> wrote:
> > diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
> > index 07ef2c3..a6863e2 100644
> > --- a/include/uapi/linux/openvswitch.h
> > +++ b/include/uapi/linux/openvswitch.h
> > @@ -40,7 +40,15 @@ struct ovs_header {
> >
> > #define OVS_DATAPATH_FAMILY "ovs_datapath"
> > #define OVS_DATAPATH_MCGROUP "ovs_datapath"
> > -#define OVS_DATAPATH_VERSION 0x1
> > +
> > +/* V2:
> > + * - API users are expected to provide OVS_DP_ATTR_USER_FEATURES
> > + * with NLM_F_REPLACE when creating the datapath.
> > + */
> > +#define OVS_DATAPATH_VERSION 2
>
> I'm not sure that I understand this comment - I guess it means that
> there's no legacy path when using NLM_F_REPLACE?
It means that if the V2 caller does not provide user features the
existing user features are preserved upon NLM_F_REPLACE. V1 users
can't be aware and the user features are always reset.
next prev parent reply other threads:[~2013-11-27 22:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 16:56 [PATCH net-next 0/8 v7] Open vSwitch upcall optimiziations Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 1/8] genl: Add genlmsg_new_unicast() for unicast message allocation Thomas Graf
[not found] ` <cover.1385137618.git.tgraf-G/eBtMaohhA@public.gmane.org>
2013-11-22 16:56 ` [PATCH net-next 2/8] netlink: Avoid netlink mmap alloc if msg size exceeds frame size Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 3/8] openvswitch: Enable memory mapped Netlink i/o Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 4/8] net: Export skb_zerocopy() to zerocopy from one skb to another Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 5/8] openvswitch: Allow user space to announce ability to accept unaligned Netlink messages Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 6/8] openvswitch: Allow update of dp with OVS_DP_CMD_NEW if NLM_F_REPLACE is set Thomas Graf
[not found] ` <2b77b94f043dbed36a08dcc0a876830d6ad1a97a.1385137618.git.tgraf-G/eBtMaohhA@public.gmane.org>
2013-11-25 21:23 ` Jesse Gross
2013-11-27 22:32 ` Thomas Graf
2013-11-22 16:56 ` [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath Thomas Graf
2013-11-25 23:40 ` Jesse Gross
2013-11-27 22:35 ` Thomas Graf [this message]
2013-11-22 16:56 ` [PATCH net-next 8/8] openvswitch: Use skb_zerocopy() for upcall Thomas Graf
-- strict thread matches above, loose matches on Subject: below --
2013-11-21 18:13 [PATCH net-next 0/8 v6] Open vSwitch upcall optimiziations Thomas Graf
2013-11-21 18:13 ` [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath Thomas Graf
2013-11-21 18:23 ` Ben Hutchings
2013-11-21 22:20 ` Thomas Graf
2013-11-21 23:50 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127223512.GB26084@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=eric.dumazet@gmail.com \
--cc=ffusco@redhat.com \
--cc=fleitner@redhat.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).