netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic
@ 2013-11-25 16:52 Andy Whitcroft
  2013-11-25 16:54 ` Ian Campbell
  2013-11-28 23:38 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Whitcroft @ 2013-11-25 16:52 UTC (permalink / raw)
  To: Ian Campbell, Wei Liu, xen-devel; +Cc: Andy Whitcroft, netdev, linux-kernel

We are now using csum_ipv6_magic, include the appropriate header.
Avoids the following error:

    drivers/net/xen-netback/netback.c:1313:4: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
        tcph->check = ~csum_ipv6_magic(&ipv6h->saddr,

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 drivers/net/xen-netback/netback.c | 1 +
 1 file changed, 1 insertion(+)

    Found while trying to couple latest kernels for arm64 platforms.
    Looks like it got missed in the transition.

    -apw

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 919b650..64f0e0d 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -39,6 +39,7 @@
 #include <linux/udp.h>
 
 #include <net/tcp.h>
+#include <net/ip6_checksum.h>
 
 #include <xen/xen.h>
 #include <xen/events.h>
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic
  2013-11-25 16:52 [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic Andy Whitcroft
@ 2013-11-25 16:54 ` Ian Campbell
  2013-11-28 23:38 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2013-11-25 16:54 UTC (permalink / raw)
  To: Andy Whitcroft; +Cc: Wei Liu, xen-devel, netdev, linux-kernel

On Mon, 2013-11-25 at 16:52 +0000, Andy Whitcroft wrote:
> We are now using csum_ipv6_magic, include the appropriate header.
> Avoids the following error:
> 
>     drivers/net/xen-netback/netback.c:1313:4: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>         tcph->check = ~csum_ipv6_magic(&ipv6h->saddr,
> 
> Signed-off-by: Andy Whitcroft <apw@canonical.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks!

> ---
>  drivers/net/xen-netback/netback.c | 1 +
>  1 file changed, 1 insertion(+)
> 
>     Found while trying to couple latest kernels for arm64 platforms.
>     Looks like it got missed in the transition.
> 
>     -apw
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 919b650..64f0e0d 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -39,6 +39,7 @@
>  #include <linux/udp.h>
>  
>  #include <net/tcp.h>
> +#include <net/ip6_checksum.h>
>  
>  #include <xen/xen.h>
>  #include <xen/events.h>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic
  2013-11-25 16:52 [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic Andy Whitcroft
  2013-11-25 16:54 ` Ian Campbell
@ 2013-11-28 23:38 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-11-28 23:38 UTC (permalink / raw)
  To: apw; +Cc: ian.campbell, wei.liu2, xen-devel, netdev, linux-kernel

From: Andy Whitcroft <apw@canonical.com>
Date: Mon, 25 Nov 2013 16:52:34 +0000

> We are now using csum_ipv6_magic, include the appropriate header.
> Avoids the following error:
> 
>     drivers/net/xen-netback/netback.c:1313:4: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>         tcph->check = ~csum_ipv6_magic(&ipv6h->saddr,
> 
> Signed-off-by: Andy Whitcroft <apw@canonical.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-28 23:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 16:52 [PATCH 1/1] xen-netback: include definition of csum_ipv6_magic Andy Whitcroft
2013-11-25 16:54 ` Ian Campbell
2013-11-28 23:38 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).