From: David Chang <dchang@suse.com>
To: hayeswang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, "'David S. Miller'" <davem@davemloft.net>,
'Francois Romieu' <romieu@fr.zoreil.com>,
jlee@suse.com, 'nic_swsd' <nic_swsd@realtek.com>
Subject: Re: [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g
Date: Thu, 28 Nov 2013 12:29:04 +0800 [thread overview]
Message-ID: <20131128042904.GA9297@linux-g7tt.site> (raw)
In-Reply-To: <103D217663F345E1877FB05AC93E3CFF@realtek.com.tw>
On Thu, Nov 28, 2013 at 11:37:18AM +0800, hayeswang wrote:
> David Chang [mailto:dchang@suse.com]
> > Sent: Wednesday, November 27, 2013 3:49 PM
> > To: netdev@vger.kernel.org
> > Cc: David S. Miller; Francois Romieu; Hayeswang; jlee@suse.com
> > Subject: [PATCH net] r8169: check ALDPS bit and disable it if
> > enabled for the 8168g
> >
> [...]
> > + /* Check ALDPS bit, disable it if enabled */
> > + rtl_writephy(tp, 0x1f, 0x0a43);
> > + if (rtl_readphy(tp, 0x10) & 0x0004)
> > + rtl_w1w0_phy(tp, 0x10, 0x0000, 0x0004);
> > +
>
> You have to delay at least 10 ms after disable it.
> This makes sure the hw completes the action.
>
Thanks for your comment.
I'd add a delay time and send the v2 version.
Regards,
David
> Best Regards,
> Hayes
>
>
next prev parent reply other threads:[~2013-11-28 4:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 7:48 [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g David Chang
2013-11-28 0:02 ` Francois Romieu
2013-11-28 3:37 ` [PATCH net] r8169: check ALDPS bit and disable it if enabled forthe 8168g hayeswang
2013-11-28 3:37 ` [PATCH net] r8169: check ALDPS bit and disable it if enabled for the 8168g hayeswang
2013-11-28 4:29 ` David Chang [this message]
2013-11-28 5:28 ` [PATCH net] r8169: check ALDPS bit and disable it if enabled forthe 8168g hayeswang
2013-11-28 6:22 ` David Chang
2013-11-28 7:58 ` [PATCH net] r8169: check ALDPS bit and disable it if enabledforthe 8168g hayeswang
2013-11-29 21:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128042904.GA9297@linux-g7tt.site \
--to=dchang@suse.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=jlee@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).