From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH v2] inet: fix possible seqlock deadlocks Date: Thu, 28 Nov 2013 19:09:14 +0100 Message-ID: <20131128180914.GA24171@order.stressinduktion.org> References: <13025162.118881385612276530.JavaMail.weblogic@epv6ml01> <1385659390.5352.20.camel@edumazet-glaptop2.roam.corp.google.com> <1385661082.5352.34.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: jongman.heo@samsung.com, David Miller , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: <1385661082.5352.34.camel@edumazet-glaptop2.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Nov 28, 2013 at 09:51:22AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In commit c9e9042994d3 ("ipv4: fix possible seqlock deadlock") I left > another places where IP_INC_STATS_BH() were improperly used. > > udp_sendmsg(), ping_v4_sendmsg() and tcp_v4_connect() are called from > process context, not from softirq context. > > This was detected by lockdep seqlock support. > > Reported-by: jongman heo > Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP") > Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind") > Signed-off-by: Eric Dumazet > Cc: Hannes Frederic Sowa Just got home after getting distracted with other things today and the work is already done. Thanks, Eric! ;) Exactly the spots I noticed this morning, so Acked-by: Hannes Frederic Sowa Should we do something about the naming? I find it rather dangerous because they look like the _bh lock postfixes but act exactly in the opposite? Greetings, Hannes