From: David Miller <davem@davemloft.net>
To: yangyingliang@huawei.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
dwmw2@infradead.org, dave.taht@bufferbloat.net
Subject: Re: [PATCH v2] net: 8139cp: fix a BUG_ON triggered by wrong bytes_compl
Date: Fri, 29 Nov 2013 16:19:20 -0500 (EST) [thread overview]
Message-ID: <20131129.161920.119393762714075664.davem@davemloft.net> (raw)
In-Reply-To: <52959214.7000501@huawei.com>
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Wed, 27 Nov 2013 14:32:52 +0800
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> Using iperf to send packets(GSO mode is on), a bug is triggered:
...
> When a skb has frags, bytes_compl plus skb->len nr_frags times in cp_tx().
> It's not the correct value(actually, it should plus skb->len once) and it
> will trigger the BUG_ON(bytes_compl > num_queued - dql->num_completed).
> So only increase bytes_compl when finish sending all frags. pkts_compl also
> has a wrong value, fix it too.
>
> It's introduced by commit 871f0d4c("8139cp: enable bql").
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-11-29 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 4:07 [PATCH] net: 8139cp: fix a BUG_ON triggered by wrong bytes_compl Yang Yingliang
2013-11-27 4:35 ` Eric Dumazet
2013-11-27 6:05 ` Yang Yingliang
2013-11-27 6:32 ` [PATCH v2] " Yang Yingliang
2013-11-29 21:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129.161920.119393762714075664.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.taht@bufferbloat.net \
--cc=dwmw2@infradead.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).