From: David Miller <davem@davemloft.net>
To: hariprasad@chelsio.com
Cc: netdev@vger.kernel.org, dm@chelsio.com, leedom@chelsio.com,
nirranjan@chelsio.com, kumaras@chelsio.com
Subject: Re: [PATCH net 0/3] Fixes T5 adapter init, due to incorrect FW version check
Date: Fri, 29 Nov 2013 16:45:18 -0500 (EST) [thread overview]
Message-ID: <20131129.164518.76867516422095836.davem@davemloft.net> (raw)
In-Reply-To: <1385646734-3576-1-git-send-email-hariprasad@chelsio.com>
From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Thu, 28 Nov 2013 19:22:11 +0530
> This patch series fixes, Chelsio T5 adapter initialization failure due to
> incorrect firmware version check. This patch series modifies the firmware
> flashing mechanism for T4/T5 adapter. It adds a new module parameter
> t4_fw_install to control firmware flashing.
Module parameters are strongly discouraged, please find another way to
control this attribute, preferrably at run time so that it can be changed
right before the device is openned for the first time, for example.
Also, "upgradation" is not a real word, please fix this.
prev parent reply other threads:[~2013-11-29 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 13:52 [PATCH net 0/3] Fixes T5 adapter init, due to incorrect FW version check Hariprasad Shenai
2013-11-28 13:52 ` [PATCH net 1/3] cxgb4: Much cleaner implementation of is_t4()/is_t5() Hariprasad Shenai
2013-11-28 13:52 ` [PATCH net 2/3] cxgb4vf: added much cleaner implementation of is_t4() Hariprasad Shenai
2013-11-28 13:52 ` [PATCH net 3/3] cxgb4: Add new scheme for T4/T5 firmware upgradation Hariprasad Shenai
2013-11-29 21:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129.164518.76867516422095836.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox