netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: netdev@vger.kernel.org
Subject: [RFC] Should skb->csum include 8021Q header for CHECKSUM_COMPLETE && NETIF_F_HW_VLAN_CTAG_RX
Date: Fri, 29 Nov 2013 13:28:19 +0000	[thread overview]
Message-ID: <20131129132819.GA9176@casper.infradead.org> (raw)

Hi

Given CHECKSUM_COMPLETE, is skb->csum supposed to include the
checksum of the VLAN header if the header was stripped by the
NIC?

The answer is clear for non accelerated VLAN: it covers all of
the packet without ethernet CRC.

For the accelerated path the answer is less clear after staring
at drivers. The stack currently only fixes the csum for the
software path.

We are seeing hw csum failure warnings for drivers like enic if
OVS pops a VLAN header that was previously stripped  in hardware.
Should we force CHECKSUM_NONE like VXLAN does or are all drivers
guaranteed to include VLAN bits for CHECK_COMPLETE regardless of
acceleration?

Best,
Thomas

             reply	other threads:[~2013-11-29 13:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 13:28 Thomas Graf [this message]
2013-11-29 19:08 ` [RFC] Should skb->csum include 8021Q header for CHECKSUM_COMPLETE && NETIF_F_HW_VLAN_CTAG_RX Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131129132819.GA9176@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).