* [PATCH] sctp: check the rto_min and rto_max
@ 2013-11-30 10:23 wangweidong
2013-11-30 14:17 ` Neil Horman
2013-11-30 21:08 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: wangweidong @ 2013-11-30 10:23 UTC (permalink / raw)
To: Vlad Yasevich, nhorman, davem; +Cc: linux-sctp, netdev, dingtianhong
rto_min should be smaller than rto_max while rto_max should be larger
than rto_min. so just add the check.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/sctp/sysctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index 6b36561..7637e8e 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
.extra1 = &one,
- .extra2 = &timer_max
+ .extra2 = &init_net.sctp.rto_max
},
{
.procname = "rto_max",
@@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
.maxlen = sizeof(unsigned int),
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
- .extra1 = &one,
+ .extra1 = &init_net.sctp.rto_min,
.extra2 = &timer_max
},
{
--
1.7.12
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sctp: check the rto_min and rto_max
2013-11-30 10:23 [PATCH] sctp: check the rto_min and rto_max wangweidong
@ 2013-11-30 14:17 ` Neil Horman
2013-11-30 21:08 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Neil Horman @ 2013-11-30 14:17 UTC (permalink / raw)
To: wangweidong; +Cc: Vlad Yasevich, davem, linux-sctp, netdev, dingtianhong
On Sat, Nov 30, 2013 at 06:23:52PM +0800, wangweidong wrote:
> rto_min should be smaller than rto_max while rto_max should be larger
> than rto_min. so just add the check.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/sctp/sysctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
> index 6b36561..7637e8e 100644
> --- a/net/sctp/sysctl.c
> +++ b/net/sctp/sysctl.c
> @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = &one,
> - .extra2 = &timer_max
> + .extra2 = &init_net.sctp.rto_max
> },
> {
> .procname = "rto_max",
> @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> - .extra1 = &one,
> + .extra1 = &init_net.sctp.rto_min,
> .extra2 = &timer_max
> },
> {
> --
> 1.7.12
>
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sctp: check the rto_min and rto_max
2013-11-30 10:23 [PATCH] sctp: check the rto_min and rto_max wangweidong
2013-11-30 14:17 ` Neil Horman
@ 2013-11-30 21:08 ` David Miller
2013-12-02 1:33 ` Wang Weidong
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2013-11-30 21:08 UTC (permalink / raw)
To: wangweidong1; +Cc: vyasevich, nhorman, linux-sctp, netdev, dingtianhong
From: wangweidong <wangweidong1@huawei.com>
Date: Sat, 30 Nov 2013 18:23:52 +0800
> rto_min should be smaller than rto_max while rto_max should be larger
> than rto_min. so just add the check.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Please fix your submission process such that your real full name
appears in the "From: " field of your patch emails, instead of
just "wangweidong", which is your username not your real full
name.
I'm not applying your patches until you correct this and submit
the patch properly, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sctp: check the rto_min and rto_max
2013-11-30 21:08 ` David Miller
@ 2013-12-02 1:33 ` Wang Weidong
0 siblings, 0 replies; 4+ messages in thread
From: Wang Weidong @ 2013-12-02 1:33 UTC (permalink / raw)
To: David Miller; +Cc: vyasevich, nhorman, linux-sctp, netdev, dingtianhong
On 2013/12/1 5:08, David Miller wrote:
> From: wangweidong <wangweidong1@huawei.com>
> Date: Sat, 30 Nov 2013 18:23:52 +0800
>
>> rto_min should be smaller than rto_max while rto_max should be larger
>> than rto_min. so just add the check.
>>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>
> Please fix your submission process such that your real full name
> appears in the "From: " field of your patch emails, instead of
> just "wangweidong", which is your username not your real full
> name.
>
> I'm not applying your patches until you correct this and submit
> the patch properly, thanks.
>
Ok, I will fix it in v2.
Thanks.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-02 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-30 10:23 [PATCH] sctp: check the rto_min and rto_max wangweidong
2013-11-30 14:17 ` Neil Horman
2013-11-30 21:08 ` David Miller
2013-12-02 1:33 ` Wang Weidong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).