From: David Miller <davem@davemloft.net>
To: wei.liu2@citrix.com
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org,
netdev@vger.kernel.org, stable@vger.kernel.org,
tomasz.wroblewski@citrix.com, konrad.wilk@oracle.com,
david.vrabel@citrix.com
Subject: Re: [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions
Date: Sat, 30 Nov 2013 16:19:11 -0500 (EST) [thread overview]
Message-ID: <20131130.161911.986012805406716752.davem@davemloft.net> (raw)
In-Reply-To: <20131128131346.GK12187@zion.uk.xensource.com>
From: Wei Liu <wei.liu2@citrix.com>
Date: Thu, 28 Nov 2013 13:13:46 +0000
> On Thu, Nov 28, 2013 at 01:08:53PM +0000, Ian Campbell wrote:
>> On Thu, 2013-11-28 at 12:48 +0000, Wei Liu wrote:
>> > With the introduction of "xen-netback: Don't destroy the netdev until
>> > the vif is shut down" (upstream commit id 279f438e36), vif disconnect
>> > and free are separated. However in the backported verion reference
>> > counting code was not correctly modified, and the reset of vif->tx_irq
>> > was lost. If frontend goes through vif life cycle more than once the
>> > reference counting is skewed.
>> >
>> > This patch adds back the missing tx_irq reset line. It also moves
>> > several lines of the reference counting code to vif_free, so the moved
>> > code corresponds to the counterpart in vif_alloc, thus the reference
>> > counting is balanced.
>>
>> Is this a requirement of the bugfix or just to make reasoning about
>> things easier?
>>
>
> The latter.
I've queued this up for -stable, thanks.
next prev parent reply other threads:[~2013-11-30 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 12:48 [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions Wei Liu
2013-11-28 13:08 ` Ian Campbell
2013-11-28 13:13 ` Wei Liu
2013-11-30 21:19 ` David Miller [this message]
2013-12-01 4:48 ` Greg KH
2013-12-02 12:01 ` Wei Liu
2013-12-02 17:19 ` Greg KH
2013-12-02 17:49 ` Wei Liu
2013-12-02 17:58 ` Greg KH
2013-12-02 17:59 ` Patch "xen-netback: fix refcnt unbalance for 3.10" has been added to the 3.10-stable tree gregkh
2013-12-20 10:02 ` [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130.161911.986012805406716752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.wroblewski@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).