From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: gaofeng@cn.fujitsu.com, yoshfuji@linux-ipv6.org, joe@perches.com,
vfalico@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: neighbour: make sure the handler has finished before kfree neighbour
Date: Sat, 30 Nov 2013 16:27:33 -0500 (EST) [thread overview]
Message-ID: <20131130.162733.145727596946626316.davem@davemloft.net> (raw)
In-Reply-To: <52973704.1030202@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Thu, 28 Nov 2013 20:28:52 +0800
> I have met the oops in Suse11 SP2, the kernel is 2.6.32.59-0.7-default:
This doesn't make any sense.
If this actually was the reason, then del_timer() would have returned true,
and thus neigh_del_timer() would have returned "1" and you would have
seen the "Impossible event" log message that neigh_destroy() prints out.
You may think the cause is a pending timer, but the data you've provided
does not support this at all.
And if it isn't happening, your patch removing that warning is wrong.
Furthermore, if this change to use del_timer_sync() is correct, it
probably belongs in neigh_del_timer() because all of it's other callers
expect the timer to not be running and that all references to the object
are stable after such calls.
I'm not applying this, you really need to pursue this bug fix more
cleanly and more thoroughly because it's a non-trivial issue.
Thanks.
next prev parent reply other threads:[~2013-11-30 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 12:28 [PATCH net] net: neighbour: make sure the handler has finished before kfree neighbour Ding Tianhong
2013-11-30 21:27 ` David Miller [this message]
2013-12-01 2:43 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130.162733.145727596946626316.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).