netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: venkat.x.venkatsubra@oracle.com
Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org,
	honli@redhat.com, joshhunt00@gmail.com, bang.nguyen@oracle.com
Subject: Re: [PATCH] rds: prevent BUG_ON triggered on congestion update to loopback
Date: Sun, 01 Dec 2013 20:19:30 -0500 (EST)	[thread overview]
Message-ID: <20131201.201930.2009545384899801860.davem@davemloft.net> (raw)
In-Reply-To: <1385167442-6997-1-git-send-email-venkat.x.venkatsubra@oracle.com>

From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Date: Mon, 25 Nov 2013 09:47:34 +0300

> From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
> 
> After congestion update on a local connection, when rds_ib_xmit returns
> less bytes than that are there in the message, rds_send_xmit calls
> back rds_ib_xmit with an offset that causes BUG_ON(off & RDS_FRAG_SIZE)
> to trigger.
> 
> Reported-by: Josh Hunt <joshhunt00@gmail.com>
> Tested-by: Honggang Li <honli@redhat.com>
> Acked-by: Bang Nguyen <bang.nguyen@oracle.com>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Venkat, this is almost perfect.

Please adjust the commit message so that it contains all of the analysis
you posted before.  You can never include too much information, especially
for a fix for a bug that languished for such a long time like this one
did.  In particular you should mentioned the ppc bug fix that introduced
this regression, reference such commits in the following format:

	$SHA1_ID ("Commit message header text")

Thanks.

  reply	other threads:[~2013-12-02  1:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  6:47 [PATCH] rds: prevent BUG_ON triggered on congestion update to loopback Venkat Venkatsubra
2013-12-02  1:19 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-12-02 23:41 Venkat Venkatsubra
2013-12-03 16:55 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131201.201930.2009545384899801860.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bang.nguyen@oracle.com \
    --cc=honli@redhat.com \
    --cc=joshhunt00@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=venkat.x.venkatsubra@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).