From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: mwdalton@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, edumazet@google.com
Subject: Re: [PATCH v2 1/2] virtio_net: fix error handling for mergeable buffers
Date: Sun, 01 Dec 2013 20:27:52 -0500 (EST) [thread overview]
Message-ID: <20131201.202752.1283570881734672398.davem@davemloft.net> (raw)
In-Reply-To: <1385638044-27467-1-git-send-email-mst@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 28 Nov 2013 13:30:55 +0200
> Eric Dumazet noticed that if we encounter an error
> when processing a mergeable buffer, we don't
> dequeue all of the buffers from this packet,
> the result is almost sure to be loss of networking.
>
> Jason Wang noticed that we also leak a page and that we don't decrement
> the rq buf count, so we won't repost buffers (a resource leak).
>
> Fix both issues.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Michael Dalton <mwdalton@google.com>
> Reported-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
prev parent reply other threads:[~2013-12-02 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 11:30 [PATCH v2 1/2] virtio_net: fix error handling for mergeable buffers Michael S. Tsirkin
2013-11-28 11:30 ` [PATCH v2 2/2] virtio-net: make all RX paths handle erors consistently Michael S. Tsirkin
2013-12-02 1:28 ` David Miller
2013-11-29 10:13 ` [PATCH v2 1/2] virtio_net: fix error handling for mergeable buffers Jason Wang
2013-12-02 1:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131201.202752.1283570881734672398.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).