From: David Miller <davem@davemloft.net>
To: agraf@suse.de
Cc: herbert@gondor.apana.org.au, alexander.h.duyck@intel.com,
netdev@vger.kernel.org, edumazet@google.com,
herbert@gondor.apana.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org
Subject: Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...)
Date: Mon, 02 Dec 2013 13:59:02 -0500 (EST) [thread overview]
Message-ID: <20131202.135902.408377838919681103.davem@davemloft.net> (raw)
In-Reply-To: <B8BCE323-6F65-4D14-BD4A-BFA07C3ED290@suse.de>
From: Alexander Graf <agraf@suse.de>
Date: Fri, 22 Nov 2013 19:08:16 +0100
> With current Linus' master tree my ibook started emitting a lot of
> annoying csum calculation warnings. I've bisected it down to the
> commit seen in the subject line, but I suppose the real problem lies
> somewhere a lot deeper and only gets revealed thanks to the more
> clever checksum logic applied now.
>
> Any ideas how to dig further into this?
Ok, I'm going to revert this commit, for several reasons.
In addition to the problem you are running into, it just occurred to me
that if the __pskb_trim() call fails, we'll leave a corrupted checksum
in the SKB.
Thanks for your report.
prev parent reply other threads:[~2013-12-02 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 18:08 gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more adequately ...) Alexander Graf
2013-11-23 1:47 ` Herbert Xu
2013-12-02 18:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202.135902.408377838919681103.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agraf@suse.de \
--cc=alexander.h.duyck@intel.com \
--cc=benh@kernel.crashing.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).