From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: duanj.fnst@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: judge the accept_ra_defrtr before calling rt6_route_rcv
Date: Mon, 02 Dec 2013 16:01:07 -0500 (EST) [thread overview]
Message-ID: <20131202.160107.287731047825113467.davem@davemloft.net> (raw)
In-Reply-To: <20131129060945.GJ24171@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 29 Nov 2013 07:09:45 +0100
> On Tue, Nov 26, 2013 at 03:46:56PM +0800, Duan Jiong wrote:
>>
>> when dealing with a RA message, if accept_ra_defrtr is false,
>> the kernel will not add the default route, and then deal with
>> the following route information options. Unfortunately, those
>> options maybe contain default route, so let's judge the
>> accept_ra_defrtr before calling rt6_route_rcv.
>>
>> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>
> I am ambivalent regarding this change.
>
> accept_ra_defrtr protected against adding default routers without routing
> options and accept_ra_rt_info_max_plen == -1 disables the acceptance of any
> routing options in router advertisments.
>
> I don't have an idea why we need this distinction altough I once used it for
> testing. But because this change makes it more understandable for users I am
> ok with that.
I've applied this, thanks everyone.
prev parent reply other threads:[~2013-12-02 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 7:46 [PATCH] ipv6: judge the accept_ra_defrtr before calling rt6_route_rcv Duan Jiong
2013-11-29 6:09 ` Hannes Frederic Sowa
2013-12-02 21:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202.160107.287731047825113467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).