* [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet
@ 2013-12-02 7:23 Mugunthan V N
2013-12-02 21:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mugunthan V N @ 2013-12-02 7:23 UTC (permalink / raw)
To: netdev; +Cc: davem, linux-omap, Mugunthan V N
When only one port of the two port is pinned out, then dt probe is failing
because second port phy is not found. fixing this by checking the number of
slaves and breaking the loop.
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
drivers/net/ethernet/ti/cpsw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 90d41d2..68ef9f2 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1813,6 +1813,8 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
}
i++;
+ if (i == data->slaves)
+ break;
}
return 0;
--
1.8.5.rc3.2.gc302941
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet
2013-12-02 7:23 [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet Mugunthan V N
@ 2013-12-02 21:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-12-02 21:56 UTC (permalink / raw)
To: mugunthanvnm; +Cc: netdev, linux-omap
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Mon, 2 Dec 2013 12:53:39 +0530
> When only one port of the two port is pinned out, then dt probe is failing
> because second port phy is not found. fixing this by checking the number of
> slaves and breaking the loop.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Of course, this patch assumes that slaves are pinned out in order.
But, no matter, this makes more configurations work than before so
it's a good patch.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-02 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-02 7:23 [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet Mugunthan V N
2013-12-02 21:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).