From: David Miller <davem@davemloft.net>
To: paul.durrant@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org,
zoltan.kiss@citrix.com, wei.liu2@citrix.com,
ian.campbell@citrix.com, david.vrabel@citrix.com
Subject: Re: [PATCH net v5] xen-netback: fix fragment detection in checksum setup
Date: Thu, 05 Dec 2013 20:32:54 -0500 (EST) [thread overview]
Message-ID: <20131205.203254.200366522595946707.davem@davemloft.net> (raw)
In-Reply-To: <1386092369-13618-1-git-send-email-paul.durrant@citrix.com>
From: Paul Durrant <paul.durrant@citrix.com>
Date: Tue, 3 Dec 2013 17:39:29 +0000
> The code to detect fragments in checksum_setup() was missing for IPv4 and
> too eager for IPv6. (It transpires that Windows seems to send IPv6 packets
> with a fragment header even if they are not a fragment - i.e. offset is zero,
> and M bit is not set).
>
> This patch also incorporates a fix to callers of maybe_pull_tail() where
> skb->network_header was being erroneously added to the length argument.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
Applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2013-12-06 1:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 17:39 [PATCH net v5] xen-netback: fix fragment detection in checksum setup Paul Durrant
2013-12-05 6:28 ` annie li
2013-12-05 9:08 ` Paul Durrant
2013-12-05 10:00 ` [Xen-devel] " annie li
2013-12-05 10:45 ` Paul Durrant
2013-12-05 13:11 ` annie li
2013-12-05 14:53 ` Wei Liu
2013-12-06 1:32 ` David Miller [this message]
2013-12-10 16:11 ` [Xen-devel] " Jan Beulich
2013-12-10 16:24 ` Paul Durrant
2013-12-10 16:58 ` Jan Beulich
2013-12-10 17:29 ` Paul Durrant
2013-12-11 7:27 ` Jan Beulich
2013-12-10 17:12 ` Eric Dumazet
2013-12-11 9:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205.203254.200366522595946707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).