From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v5] xen-netback: fix fragment detection in checksum setup Date: Thu, 05 Dec 2013 20:32:54 -0500 (EST) Message-ID: <20131205.203254.200366522595946707.davem@davemloft.net> References: <1386092369-13618-1-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org, zoltan.kiss@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, david.vrabel@citrix.com To: paul.durrant@citrix.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:60344 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749Ab3LFBc4 (ORCPT ); Thu, 5 Dec 2013 20:32:56 -0500 In-Reply-To: <1386092369-13618-1-git-send-email-paul.durrant@citrix.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Paul Durrant Date: Tue, 3 Dec 2013 17:39:29 +0000 > The code to detect fragments in checksum_setup() was missing for IPv4 and > too eager for IPv6. (It transpires that Windows seems to send IPv6 packets > with a fragment header even if they are not a fragment - i.e. offset is zero, > and M bit is not set). > > This patch also incorporates a fix to callers of maybe_pull_tail() where > skb->network_header was being erroneously added to the length argument. > > Signed-off-by: Paul Durrant > Signed-off-by: Zoltan Kiss Applied and queued up for -stable, thanks!