From: David Miller <davem@davemloft.net>
To: fan.du@windriver.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] vxlan: release rt when found circular route
Date: Fri, 06 Dec 2013 15:14:07 -0500 (EST) [thread overview]
Message-ID: <20131206.151407.756289328683473825.davem@davemloft.net> (raw)
In-Reply-To: <1386230631-2504-1-git-send-email-fan.du@windriver.com>
From: Fan Du <fan.du@windriver.com>
Date: Thu, 5 Dec 2013 16:03:51 +0800
> Otherwise causing dst memory leakage.
> Have Checked all other type tunnel device transmit implementation,
> no such things happens anymore.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
...
> @@ -1665,6 +1665,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
> }
>
> if (rt->dst.dev == dev) {
> + ip_rt_put(rt);
> netdev_dbg(dev, "circular route to %pI4\n",
> &dst->sin.sin_addr.s_addr);
> dev->stats.collisions++;
There is already a "rt_tx_error" label that will handle releasing the
'rt', so at the end of this basic block, goto rt_tx_error instead of
just plain tx_error.
Thanks.
next prev parent reply other threads:[~2013-12-06 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 8:03 [PATCH net] vxlan: release rt when found circular route Fan Du
2013-12-05 12:22 ` Eric Dumazet
2013-12-06 20:14 ` David Miller [this message]
2013-12-09 6:27 ` [PATCHv2 " Fan Du
2013-12-11 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206.151407.756289328683473825.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).