From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory Date: Fri, 06 Dec 2013 15:30:58 -0500 (EST) Message-ID: <20131206.153058.1741013299538900621.davem@davemloft.net> References: <1386254181-17257-1-git-send-email-avagin@openvz.org> <1386254181-17257-3-git-send-email-avagin@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org To: avagin@openvz.org Return-path: In-Reply-To: <1386254181-17257-3-git-send-email-avagin@openvz.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Andrey Vagin Date: Thu, 5 Dec 2013 18:36:21 +0400 > free_netdev calls netif_napi_del too, but it's too late, because napi > structures are placed on vi->rq. netif_napi_add() is called from > virtnet_alloc_queues. ... > Fixes: 986a4f4d452d (virtio_net: multiqueue support) > Cc: Rusty Russell > Cc: "Michael S. Tsirkin" > Signed-off-by: Andrey Vagin Applied and queued up for -stable, thanks.