From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: mareklindner@neomailbox.ch, sw@simonwunderlich.de,
antonio@meshcoding.com, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth
Date: Fri, 06 Dec 2013 15:39:44 -0500 (EST) [thread overview]
Message-ID: <20131206.153944.1382127535160341376.davem@davemloft.net> (raw)
In-Reply-To: <1386317890.31845.26.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Fri, 06 Dec 2013 00:18:10 -0800
> @@ -266,7 +266,11 @@ static inline void batadv_dbg(int type __always_unused,
> */
> static inline int batadv_compare_eth(const void *data1, const void *data2)
> {
> - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
> + return ether_addr_equal(data1, data2);
> +#else
> + return memcmp(data1, data2, ETH_ALEN) == 0;
> +#endif
> }
Let's not crap up implementations with these ifdefs.
What's the specific situation here? Is it that 'data1' and/or
'data2' my not be u16 aligned?
If so, make a function for that in linux/etherdevice.h and invoke it
in such places. You can name it something like
"ether_addr_equal_unaligned()" or similar.
Thanks.
next prev parent reply other threads:[~2013-12-06 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 8:18 [PATCH -next] batadv: Slight optimization of batadv_compare_eth Joe Perches
2013-12-06 10:10 ` Antonio Quartulli
2013-12-06 20:39 ` David Miller [this message]
[not found] ` <20131206.153944.1382127535160341376.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-06 21:17 ` Joe Perches
2013-12-06 21:38 ` David Miller
[not found] ` <20131206.163806.1555069105347405484.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-06 22:21 ` [PATCH -next] etherdevice: Add ether_addr_equal_unaligned Joe Perches
2013-12-06 22:39 ` [PATCH -next] batadv: Slight optimization of batadv_compare_eth Joe Perches
2013-12-10 1:58 ` David Miller
2013-12-06 23:44 ` [PATCH -next] etherdevice: Optimize a few is_<foo>_ether_addr functions Joe Perches
2013-12-10 1:58 ` David Miller
2013-12-10 1:58 ` [PATCH -next] etherdevice: Add ether_addr_equal_unaligned David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206.153944.1382127535160341376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).