netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, brett.ciphery@windriver.com
Subject: Re: [PATCH] ipv6: don't count addrconf generated routes against gc limit
Date: Fri, 06 Dec 2013 16:21:24 -0500 (EST)	[thread overview]
Message-ID: <20131206.162124.1642753475890720004.davem@davemloft.net> (raw)
In-Reply-To: <20131206172556.GF26746@order.stressinduktion.org>

From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 6 Dec 2013 18:25:56 +0100

> @@ -2166,7 +2166,8 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev,
>  				    bool anycast)
>  {
>  	struct net *net = dev_net(idev->dev);
> -	struct rt6_info *rt = ip6_dst_alloc(net, net->loopback_dev, 0, NULL);
> +	struct rt6_info *rt = ip6_dst_alloc(net, net->loopback_dev,
> +					    DST_NOCOUNT, NULL);
>  
>  	if (!rt) {
>  		net_warn_ratelimited("Maximum number of routes reached, consider increasing route/max_size\n");

So basically, we only want to count routes that will have RTF_CACHE
set on them.

This warning in the net_warn_ratelimited() is no longer relevant, only
hard memory allocation failures can result in this !rt condition.  So
please respin this patch with that warning removed.

Thanks.

  reply	other threads:[~2013-12-06 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 17:25 [PATCH] ipv6: don't count addrconf generated routes against gc limit Hannes Frederic Sowa
2013-12-06 21:21 ` David Miller [this message]
2013-12-07  2:33   ` [PATCH v2] " Hannes Frederic Sowa
2013-12-10  2:01     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131206.162124.1642753475890720004.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brett.ciphery@windriver.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).